Closed Bug 794912 Opened 7 years ago Closed 7 years ago

Remove dynamic privilege check in isCrossOriginAccessPermitted

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: bholley, Assigned: bholley)

Details

Attachments

(1 file)

I forgot this one in bug 788914. Patch coming up.
Summary: Remove dynamic universalxpconnect check in isCrossOriginAccessPermitted → Remove dynamic privilege check in isCrossOriginAccessPermitted
Attachment #665432 - Flags: review?(mrbkap) → review+
Hm, there was a debug mochitest-o orange, but it doesn't reproduce locally for me. I'm hoping it was a problem with the underlying m-c revision. Pushing linux debug-only mochitest-o:

https://tbpl.mozilla.org/?tree=Try&rev=0e06355690de
https://hg.mozilla.org/mozilla-central/rev/b198e36a7d73

Should this have a test?
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
(In reply to Ryan VanderMeulen from comment #5)
> https://hg.mozilla.org/mozilla-central/rev/b198e36a7d73
> 
> Should this have a test?

Nope. Our test suite in general hits this sufficiently hard, I think. All we're doing is ripping out a check for UniversalXPConnect.
Flags: in-testsuite? → in-testsuite-
You need to log in before you can comment on or make changes to this bug.