Closed Bug 794972 Opened 13 years ago Closed 13 years ago

nrpe classes in puppetagain are not quite right

Categories

(Infrastructure & Operations :: RelOps: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dustin, Assigned: dustin)

Details

Attachments

(1 file)

There's an 'include nrpe' in one of the toplevel classes, but init.pp is empty. Ideally, 'include nrpe' would happen at the toplevels where nrpe's allowed (toplevel::server and toplevel::slave::build), and then nrpe::check::* would be included below there as necessary. This should be a minor fix with no changes.
Attached patch bug794972.patchSplinter Review
The includes in modules/mozpool/manifests/init.pp were redundant to the same includes in modules/bmm/manifests/init.pp. This should have no effect - it is simply a refactoring.
Attachment #699937 - Flags: review?(rail)
Attachment #699937 - Flags: review?(rail) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: Server Operations: RelEng → RelOps
Product: mozilla.org → Infrastructure & Operations
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: