Enable profiling on Daily builds

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

Trunk
Thunderbird 18.0
x86
All

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

According to https://developer.mozilla.org/en-US/docs/Performance/Profiling_with_the_Built-in_Profiler#Running_the_profiler, we just need to add:

ac_add_options --enable-profiling

to the .mozconfigs for our Daily's.
You may want to stop stripping the builds of symbols as well if you plan on symbolicating on Mac.
Created attachment 665521 [details] [diff] [review]
Stab-in-the-dark patch

I'm not really savvy with our build config as it relates to our build machines, so I don't know if this patch does the job properly...

How's my driving?

Also, is there something I should be doing in here to stop stripping symbols, as Benoit suggests?
Assignee: nobody → mconley
Attachment #665521 - Flags: feedback?(mbanner)
Comment on attachment 665521 [details] [diff] [review]
Stab-in-the-dark patch

This is about right, but drop the comment and stick the line immediately under the signmar one, just like the Firefox mozconfigs (so that the diffs aren't too great).

We already have --disable-install-strip in the mac nightly mozconfigs, so we should be fine there.
Attachment #665521 - Flags: feedback?(mbanner) → feedback+
Created attachment 665592 [details] [diff] [review]
Patch v1

Good point - that comment didn't really add much.

Done and done.
Attachment #665521 - Attachment is obsolete: true
Attachment #665592 - Flags: review?(mbanner)
Comment on attachment 665592 [details] [diff] [review]
Patch v1

Whoops, wrong patch file - one sec...
Attachment #665592 - Flags: review?(mbanner)
Created attachment 665593 [details] [diff] [review]
Patch v1
Attachment #665592 - Attachment is obsolete: true
Comment on attachment 665593 [details] [diff] [review]
Patch v1

Ok, this is the real-deal here.
Attachment #665593 - Flags: review?(mbanner)
Comment on attachment 665593 [details] [diff] [review]
Patch v1

Excellent :-)

This can be landed with DONTBUILD in the comment, as it won't have any affect until the next nightlies.
Attachment #665593 - Flags: review?(mbanner) → review+
comm-central: https://hg.mozilla.org/comm-central/rev/85ae661d2a06
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.