Last Comment Bug 794988 - Enable profiling on Daily builds
: Enable profiling on Daily builds
Product: Thunderbird
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: Thunderbird 18.0
Assigned To: Mike Conley (:mconley)
Depends on:
  Show dependency treegraph
Reported: 2012-09-27 09:20 PDT by Mike Conley (:mconley)
Modified: 2012-09-27 13:31 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Stab-in-the-dark patch (3.55 KB, patch)
2012-09-27 10:02 PDT, Mike Conley (:mconley)
standard8: feedback+
Details | Diff | Splinter Review
Patch v1 (3.55 KB, patch)
2012-09-27 12:38 PDT, Mike Conley (:mconley)
no flags Details | Diff | Splinter Review
Patch v1 (3.37 KB, patch)
2012-09-27 12:39 PDT, Mike Conley (:mconley)
standard8: review+
Details | Diff | Splinter Review

Description Mike Conley (:mconley) 2012-09-27 09:20:47 PDT
According to, we just need to add:

ac_add_options --enable-profiling

to the .mozconfigs for our Daily's.
Comment 1 Benoit Girard (:BenWa) 2012-09-27 09:38:34 PDT
You may want to stop stripping the builds of symbols as well if you plan on symbolicating on Mac.
Comment 2 Mike Conley (:mconley) 2012-09-27 10:02:20 PDT
Created attachment 665521 [details] [diff] [review]
Stab-in-the-dark patch

I'm not really savvy with our build config as it relates to our build machines, so I don't know if this patch does the job properly...

How's my driving?

Also, is there something I should be doing in here to stop stripping symbols, as Benoit suggests?
Comment 3 Mark Banner (:standard8, limited time in Dec) 2012-09-27 12:26:21 PDT
Comment on attachment 665521 [details] [diff] [review]
Stab-in-the-dark patch

This is about right, but drop the comment and stick the line immediately under the signmar one, just like the Firefox mozconfigs (so that the diffs aren't too great).

We already have --disable-install-strip in the mac nightly mozconfigs, so we should be fine there.
Comment 4 Mike Conley (:mconley) 2012-09-27 12:38:06 PDT
Created attachment 665592 [details] [diff] [review]
Patch v1

Good point - that comment didn't really add much.

Done and done.
Comment 5 Mike Conley (:mconley) 2012-09-27 12:38:39 PDT
Comment on attachment 665592 [details] [diff] [review]
Patch v1

Whoops, wrong patch file - one sec...
Comment 6 Mike Conley (:mconley) 2012-09-27 12:39:09 PDT
Created attachment 665593 [details] [diff] [review]
Patch v1
Comment 7 Mike Conley (:mconley) 2012-09-27 12:39:50 PDT
Comment on attachment 665593 [details] [diff] [review]
Patch v1

Ok, this is the real-deal here.
Comment 8 Mark Banner (:standard8, limited time in Dec) 2012-09-27 13:19:47 PDT
Comment on attachment 665593 [details] [diff] [review]
Patch v1

Excellent :-)

This can be landed with DONTBUILD in the comment, as it won't have any affect until the next nightlies.
Comment 9 Mike Conley (:mconley) 2012-09-27 13:31:35 PDT

Note You need to log in before you can comment on or make changes to this bug.