795061 - AssertAppProcessPermission: Kill any process that doesn't have the specified permission, not just app processes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Philipp von Weitershausen [:philikon]]

Bug 776850 got the logic slightly wrong. We bail out of AssertAppProcessPermission if we can't find an app associated with a process (which would be the case for regular <iframe mozbrowser> or <browser> elements), so we never end up killing it.

Kill kill kill them all.

Comment 1

[Philipp von Weitershausen [:philikon]]

Needs to block. Don't want pwned phone.

Comment 2

[Philipp von Weitershausen [:philikon]]

Attachment: v1

Try build: https://tbpl.mozilla.org/?tree=Try&rev=0d62f643987e

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 665808 [details] [diff] [review]
v1


>diff --git a/dom/ipc/AppProcessPermissions.cpp b/dom/ipc/AppProcessPermissions.cpp

>+  if (!hasPermission) {
>+    printf_stderr("Security problem: App process does not have `%s' permission.  It will be killed.\n", aPermission);

s/App/Content/

Comment 4

[Andrew Overholt [:overholt]]

Security is important enough for blocking :)

Comment 5

[Philipp von Weitershausen [:philikon]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e81ac71f1107

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e81ac71f1107