795077 - Derby banners are shown outside the Derby where they are earned

Status: RESOLVED WONTFIX

(developer.mozilla.org Graveyard :: Demo Studio / Dev Derby, defect, P2)

Description

[John Karahalis [:openjck]]

If a demo is a finalist or winner of a Dev Derby, a colored banner appears above that demo's thumbnail. These banner are displayed throughout the Demo Studio, which can be confusing at times.

For example, take a look at the September 2012 entries (https://developer.mozilla.org/en-US/demos/devderby/2012/september). The demo "Meet me there" has a "Second Place" banner, even though (at the time of this writing) it has not won second place in that Derby. The banner is appearing because it won second place in a different Derby.

Things can get pretty confusing on the Demo Studio, too. If you browse through the demos, you can see multiple demos with (for example) a "First Place" banner.

Both of these issues could be solved by only showing banners in the Derby that the banner was won.

Comment 1

[John Karahalis [:openjck]]

Comment 0 is slightly out of date. "Meet me there" ended up winning third place. The problem is still more-or-less the same, but a little more visible.

What did you do?
================
1. Visit https://developer.mozilla.org/demos/devderby/2012/september

What happened?
==============
"Meet me there" won third place, but actually has a "Second Place" banner because it won second place the month before. As I mention in comment 0, this was a problem even before the winners were announced. At that time, "Meet me there" had a "Second Place" banner even though no winners had been announced.

What should have happened?
==========================
Before the winners were announced, "Meet me there" should not have had a banner on the September 2012 landing page, and a "Second Place" banner in the August landing page. After "Meet me there" was named as the third place winner for September, it should have had only a "Third Place" banner on the September landing page and a "Second Place" banner on the August landing page.

Is there anything else we should know?
======================================

Comment 2

[Les Orchard [:lorchard]]

Part of this seems conflated with re-submitting the same demo for multiple derbies. I thought we locked them and required creation of a new demo for a new derby, if only to freeze the source used and not allow tweaks past the date of the competition?

Also, seems like this could use some design thought as to how to present these banners, especially if we do anticipate multiple honors for the same demo

Comment 3

[John Karahalis [:openjck]]

The rules do allow a contestant to submit a demo to a second Derby. I always assumed that we wanted to use the same exact submission (the rules mention contacting one of us to do it manually), but I think you make a good point about just asking them to submit a new demo.

Ideally, I would love if demos were tied to Git repositories, and each Derby submission was just the repo at a particular tag. But I will open a separate bug about that later.

Still, might be worth fixing for the existing problem.

Comment 4

[Les Orchard [:lorchard]]

(In reply to John Karahalis [:openjck] from comment #3)
> The rules do allow a contestant to submit a demo to a second Derby. I always
> assumed that we wanted to use the same exact submission (the rules mention
> contacting one of us to do it manually), but I think you make a good point
> about just asking them to submit a new demo.

I don't recall the bug #, but I seem to remember we implemented logic to prevent changes to a demo after the finish date of a derby submission. Submitting new demos for new derbies were a part of that discussion, I think

> Ideally, I would love if demos were tied to Git repositories, and each Derby
> submission was just the repo at a particular tag. But I will open a separate
> bug about that later.
> 
> Still, might be worth fixing for the existing problem.

Yeah, that's a different issue, and I don't think we should require all demo authors to use github. Github integration should be a nice addition, but I don't think we should pin functionality on them

Comment 5

[Les Orchard [:lorchard]]

Oof, found the bug for reference, and it's ancient:

https://bugzilla.mozilla.org/show_bug.cgi?id=672962#c1

Could go either way with this, I think: Either require fresh submissions for subsequent derbies (technically simpler), or allow refreshes to existing demos & rethink how multiple derby wins are displayed (technically harder, needs some design consideration)

If we allow demos to be repeat submissions to derbies, we probably want to rework the edit freeze to be temporary for the span of the derby judging period so entrants can't continue to tweak

Comment 6

[John Karahalis [:openjck]]

(In reply to Les Orchard [:lorchard] from comment #4)
> I don't recall the bug #, but I seem to remember we implemented logic to
> prevent changes to a demo after the finish date of a derby submission.
> Submitting new demos for new derbies were a part of that discussion, I think

Yeah. Impossible to change a demo after the Derby ends.

Comment 7

[Luke Crouch [:groovecoder]]

Multiple derby wins on a single demo might be cool, but it might be easier to just track derby wins by contributor instead? And give them some cool little avatar medals or something?

Comment 8

[John Karahalis [:openjck]]

Still happens, I am almost certain.

Comment 9

[ali spivak]

Demo Studio is being removed from MDN and archived as of end January 2016