795090 - Camera - Add limit on video recorded file size and the recording duration

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[Inder]

User Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111107 Ubuntu/10.04 (lucid) Firefox/3.6.24
Build ID: 20111107172717

Steps to reproduce:

Currently there is no limit imposed on recorded file size or the maximum recording time. So, if the camcorder recording is left ON then this can fill the file system and cause other issues.



Expected results:

There should be limit imposed on the recorded file size for example by checking the available space on the file system and setting the limit to e.g. 80% of the available space. There could also be constraint put on the duration of the recording.

Comment 1

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Though I wouldn't want to impose any arbitrary limits like 80% of sdcard space. We should allow filling up the sdcard with a video if that's what the user wants to do. However we should make sure to stop early enough that we simply don't write until one of the writes fail since that will likely result in a corrupted video file.

Comment 2

[Dale Harvey (:daleharvey)]

Sounds good by me, I will just check the rate at which the video is filling the card then stop it 10 seconds or so short of being full

Comment 3

[Alex Keybl [:akeybl]]

We're worried about data loss here. Marking as a P1.

Comment 4

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Dale Harvey (:dale) from comment #2)
> Sounds good by me, I will just check the rate at which the video is filling
> the card then stop it 10 seconds or so short of being full

Or we can do that too.  I wonder if the FS driver reports free space accurately in the case of an open file still being written to.

Comment 5

[Dale Harvey (:daleharvey)]

I just tested and stating the videoStorage object does take into account the file being written, so I can do this clientside, although it seems especially if we are worried about data loss that the platform should really prevent this from being able to happen (are we worried about losing the current video or actually corrupting the partition)

Comment 6

[Dale Harvey (:daleharvey)]

Pull request for this is: https://github.com/mozilla-b2g/gaia/pull/5870

I put

Comment 7

[Dale Harvey (:daleharvey)]

Vivien as the reviewer since I couldnt think of who should, feel free to defer