Closed Bug 795169 Opened 12 years ago Closed 10 years ago

Trace Malloc Allocs increase 10% on switch from gnome-vfs to gio

Categories

(Core Graveyard :: File Handling, defect)

Product:
Core Graveyard
Component:
File Handling
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1084193

People

(Reporter: karlt, Unassigned)

References

Details

(Keywords: perf) 

Previous: avg 434698.133 stddev 1143.285 of 30 runs up to revision 9b839b6340fe
    New     : avg 478325.600 stddev 1287.478 of 5 runs since revision 157f3efdee37
    Change  : +43627.467 (10% / z=38.160)
    Graph   : http://mzl.la/SSOQWT

Changeset range: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9b839b6340fe&tochange=157f3efdee37

Changesets:
  * http://hg.mozilla.org/integration/mozilla-inbound/rev/00e193643aa9
    : Karl Tomlinson <karlt+@karlt.net> - b=713802 link gio extension against libxul for tracemalloc stack functions r=bsmedberg

  * http://hg.mozilla.org/integration/mozilla-inbound/rev/e520ade90abf
    : Karl Tomlinson <karlt+@karlt.net> - b=713802 disable gnomevfs extension without --enable-gnomevfs r=glandium

  * http://hg.mozilla.org/integration/mozilla-inbound/rev/157f3efdee37
    : Karl Tomlinson <karlt+@karlt.net> - b=713802 default enable GIO support and disable GnomeVFS r=glandium


    Previous: avg 423491.267 stddev 2199.311 of 30 runs up to revision 9b839b6340fe
    New     : avg 467612.400 stddev 2461.673 of 5 runs since revision 157f3efdee37
    Change  : +44121.133 (10.4% / z=20.061)
    Graph   : http://mzl.la/SSOTC1

Changeset range: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=9b839b6340fe&tochange=157f3efdee37

Changesets:
  * http://hg.mozilla.org/integration/mozilla-inbound/rev/00e193643aa9
    : Karl Tomlinson <karlt+@karlt.net> - b=713802 link gio extension against libxul for tracemalloc stack functions r=bsmedberg

  * http://hg.mozilla.org/integration/mozilla-inbound/rev/e520ade90abf
    : Karl Tomlinson <karlt+@karlt.net> - b=713802 disable gnomevfs extension without --enable-gnomevfs r=glandium

  * http://hg.mozilla.org/integration/mozilla-inbound/rev/157f3efdee37
    : Karl Tomlinson <karlt+@karlt.net> - b=713802 default enable GIO support and disable GnomeVFS r=glandium
10% of all memory allocations for the minor role that GIO plays is crazy.
There wasn't a significant effect reported on talos benchmark timings, but this seems to indicate room for improvement.

The extra allocations do not come from themed icons because --enable-gnomeui was still set.  (bug 795144)

I doubt they come from system proxy handling because proxy prefs were switched to direct in bug 793016.

Nor are they from the GIO protocol handler as this 32-bit run (compare with first results in comment 0) with no GIO extension still had 476950 allocations.
https://tbpl.mozilla.org/php/getParsedLog.php?id=15608636&tree=Try

I think that leaves MIME type handling in uriloader/exthandler/unix/, or perhaps gsettings desktop settings in nsGNOMEShellService.cpp.
Blocks: gio
Component: General → File Handling
Product: Toolkit → Core
Whiteboard: [MemShrink]
A nightly user is reporting issues that are likely the result of the GnomeVFS to GIO switch. https://mail.mozilla.org/pipermail/nightly-testers/2012-September/001547.html
karlt:  did the memory consumption actually change?  If not, it's not really a MemShrink issue.  Also, is this something we have control over?
Whiteboard: [MemShrink]
Memory consumption did not change significantly.
It's likely not directly Gecko, but possibly something we can influence.
Don't really know because I don't know the source.
This is consistent with bug 1084193.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.