Closed Bug 795298 Opened 11 years ago Closed 11 years ago

Don't match lines that contain "TEST-PASS "

Categories

(Tree Management Graveyard :: TBPL, defect)

Product:
Tree Management Graveyard
Component:
TBPL
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Don't match TEST-PASS
1.51 KB, patch
philor
: review+
Details | Diff | Splinter Review 
In bug 776832, a test used the string:
"INFO TEST-PASS | /tests/content/base/test/test_child_process_shutdown_message.html | Observed fatal error event. - fatal should equal fatal"

This unfortunately matches:
>       || preg_match("/fatal error/", $line)  // . . . . . . . . . . . . . . . Link

We should:
(a) See if we can use "/^fatal error/" or similar (I'll need to check various link failure logs to see where it appears)
(b) Add "TEST-PASS " to the initial exclusion, alongside "TEST-INFO "
Assignee: nobody → bmo
Status: NEW → ASSIGNED

        Attachment #665876 -
        Flags: review?(philringnalda)

        Attachment #665876 -
        Flags: review?(philringnalda) → review+

    
    

    
  
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/f5d1ecec9ce2

(Push to prod should be this week sometime)
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
  
Depends on: 799720
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard

          You need to log in
          before you can comment on or make changes to this bug.