Closed
Bug 795298
Opened 12 years ago
Closed 12 years ago
Don't match lines that contain "TEST-PASS "
Categories
(Tree Management Graveyard :: TBPL, defect)
Tree Management Graveyard
TBPL
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Attachments
(1 file)
|
1.51 KB,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
In bug 776832, a test used the string:
"INFO TEST-PASS | /tests/content/base/test/test_child_process_shutdown_message.html | Observed fatal error event. - fatal should equal fatal"
This unfortunately matches:
> || preg_match("/fatal error/", $line) // . . . . . . . . . . . . . . . Link
We should:
(a) See if we can use "/^fatal error/" or similar (I'll need to check various link failure logs to see where it appears)
(b) Add "TEST-PASS " to the initial exclusion, alongside "TEST-INFO "
|
Assignee | |
Comment 1•12 years ago
|
||
|
||
Updated•12 years ago
|
Attachment #665876 -
Flags: review?(philringnalda) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/f5d1ecec9ce2
(Push to prod should be this week sometime)
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Product: Webtools → Tree Management
|
|
||
Updated•10 years ago
|
Product: Tree Management → Tree Management Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•