Don't match lines that contain "TEST-PASS "

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

Dependency tree / graph

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
In bug 776832, a test used the string:
"INFO TEST-PASS | /tests/content/base/test/test_child_process_shutdown_message.html | Observed fatal error event. - fatal should equal fatal"

This unfortunately matches:
>       || preg_match("/fatal error/", $line)  // . . . . . . . . . . . . . . . Link

We should:
(a) See if we can use "/^fatal error/" or similar (I'll need to check various link failure logs to see where it appears)
(b) Add "TEST-PASS " to the initial exclusion, alongside "TEST-INFO "
(Assignee)

Comment 1

6 years ago
Created attachment 665876 [details] [diff] [review]
Don't match TEST-PASS
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #665876 - Flags: review?(philringnalda)
Attachment #665876 - Flags: review?(philringnalda) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/f5d1ecec9ce2

(Push to prod should be this week sometime)
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Depends on: 799720
Product: Webtools → Tree Management
Product: Tree Management → Tree Management Graveyard
You need to log in before you can comment on or make changes to this bug.