795307 - Use telemetry to report touch enabled device stats

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Jim Mathies [:jimm]]

This will be an interesting stat to track as Windows 8 rolls out.

Comment 1

[Jim Mathies [:jimm]]

Attachment: patch

Adds a touch input telemetry metric for Windows. I don't think we need this on other platforms. For Android it's probably safe to assume touch input is 100%, mac doesn't support touch and with linux I don't think we care.

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 665942 [details] [diff] [review]
patch

Review of attachment 665942 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/nsLookAndFeel.cpp
@@ +45,5 @@
> +  if ((touchCapabilities & NID_READY) && 
> +      (touchCapabilities & (NID_EXTERNAL_TOUCH | NID_INTEGRATED_TOUCH))) {
> +      return 1;
> +  }
> +  return 0;

Minor nit: you could make this just:

return (touchCapabilities & NID_READY) && (...)

@@ +52,4 @@
>  nsLookAndFeel::nsLookAndFeel() : nsXPLookAndFeel()
>  {
> +  mozilla::Telemetry::Accumulate(mozilla::Telemetry::TOUCH_ENABLED_DEVICE,
> +                                 !!IsTouchPresent());

You can just say IsTouchPresent() here; Accumulate() takes integers all the time anyway and the underlying machinery does the right thing with boolean histograms.

Comment 3

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c18edd01cd4

Comment 4

[(no longer active)]

This broke Windows builds so I backed it out: https://hg.mozilla.org/integration/mozilla-inbound/rev/4fc56788f874

Comment 5

[(no longer active)]

(Example: https://tbpl.mozilla.org/php/getParsedLog.php?id=15638279&tree=Mozilla-Inbound)

Comment 6

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e320e0e3ec41

with missing include.

Comment 7

[Jim Mathies [:jimm]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=15640932&tree=Mozilla-Inbound&full=1

Backed out again due to mysterious failure with zero info in the log. odd because this is on elm and is building fine.

I'll try a try build I guess, see what happens there.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e320e0e3ec41
https://hg.mozilla.org/mozilla-central/rev/f569fa9e32ae
https://hg.mozilla.org/mozilla-central/rev/843439877db3

Comment 9

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6f2ba68e685

Third time should be the charm. This time with the missing parts of the patch I somehow lost when applying the patch to inbound. This also built on try successfully.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e6f2ba68e685