795334 - Re-enable permissions tests on Mac and Win

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[David Dahl :ddahl]

The tests from bug 758269 fail on Mac (half of the checks) due to a Mac-only ASSERT:
###!!! ASSERTION: OBSERVER_KEY not found!: '[userInfo valueForKey:OBSERVER_KEY] != nil', file ../../../../../toolkit/components/alerts/mac/mozNotificationCenterDelegate.mm, line 149

The windows checks all pass, but there is another strange error that causes a timeout:
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/dom/tests/browser/browser_webapps_permissions.js | Found an unexpected alert:alert at the end of test run

Comment 1

[Reuben Morais [:reuben]]

Attachment: Re-enable tests on Mac and Win

Doesn't seem to be the case anymore, at least on OS X.
Sent to Try to see if this breaks Windows: https://tbpl.mozilla.org/?tree=Try&rev=d7a5ef394f52

Comment 2

[Mounir Lamouri (:mounir)]

Reuben, the try run still has Mac oranges, right?

Comment 3

[Reuben Morais [:reuben]]

(In reply to Mounir Lamouri (:mounir) from comment #2)
> Reuben, the try run still has Mac oranges, right?

That Try run also had a patch from bug 793204 which caused the mochitest-browser oranges. The Windows one looks different from the other failures so it's probably still broken there. I'll address the last comments in bug 793204 and send to Try again, this time without changing the mochitest-browser test.

Comment 4

[Reuben Morais [:reuben]]

Comment on attachment 706096 [details] [diff] [review]
Re-enable tests on Mac and Win

Yes, the OS X oranges happen even without my patch. Weirdly, the test passes without problems when running locally :(

Comment 5

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.