795479 - Allow B2G update channel to be passed in at build time

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Marshall Culpepper [:marshall_law]]

We need the ability to build B2G with a specific update channel from the current build system.

Comment 1

[Marshall Culpepper [:marshall_law]]

Attachment: updateChannel - v1

Just use @MOZ_UPDATE_CHANNEL@ from autoconf.

Comment 2

[Marshall Culpepper [:marshall_law]]

Matching gonk-misc pull request:
https://github.com/mozilla-b2g/gonk-misc/pull/36

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 666062 [details] [diff] [review]
updateChannel - v1

Does this default to something sane for local VARIANT=user builds?  r=me if so.

Comment 4

[Marshall Culpepper [:marshall_law]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> Does this default to something sane for local VARIANT=user builds?  r=me if
> so.

Yeah, B2G_UPDATE_CHANNEL always defaults to "nightly" when it isn't provided

Comment 5

[Marshall Culpepper [:marshall_law]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/777564a3cd50

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/777564a3cd50

Comment 8

[Robert Kaiser]

(In reply to Marshall Culpepper [:marshall_law] from comment #4)
> (In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> > Does this default to something sane for local VARIANT=user builds?  r=me if
> > so.
> 
> Yeah, B2G_UPDATE_CHANNEL always defaults to "nightly" when it isn't provided

MOZ_UPDATE_CHANNEL defaults to "default", is this a different variable?

Comment 9

[Marshall Culpepper [:marshall_law]]

(In reply to Robert Kaiser (:[e-mail]) from comment #8)
> MOZ_UPDATE_CHANNEL defaults to "default", is this a different variable?

See my pull request, our build system should be defaulting to nightly when the updater is enabled:

https://github.com/mozilla-b2g/gonk-misc/pull/36/files

Comment 10

[Robert Kaiser]

Ouch, that calls for problems or at least unexpected stuff as it means that self-compiled builds of developers will try to update to our official builds.

Comment 11

[Marshall Culpepper [:marshall_law]]

(In reply to Robert Kaiser (:[e-mail]) from comment #10)
> Ouch, that calls for problems or at least unexpected stuff as it means that
> self-compiled builds of developers will try to update to our official builds.

By default, developer builds have the updater disabled, so it I don't think that should be a problem.

Comment 12

[Robert Kaiser]

(In reply to Marshall Culpepper [:marshall_law] from comment #11)
> By default, developer builds have the updater disabled, so it I don't think
> that should be a problem.

Interesting, so this is another difference to Firefox then, where the updater is enabled by default. Still, I also worry that if that would be there in the long run, we might get crash reports from random developer builds mixed with the official builds (if crashreporter is enabled in developer builds, which it is not with Firefox what no idea what you guys build against by default). But then, I'm pretty sure that using the "nightly" channel for unofficial build won't hold up when builds move to releng anyhow, and we won't get useful crash reports until some time after we have done that move.