Closed Bug 795479 Opened 7 years ago Closed 7 years ago

Allow B2G update channel to be passed in at build time

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: marshall, Assigned: marshall)

Details

Attachments

(1 file)

We need the ability to build B2G with a specific update channel from the current build system.
Just use @MOZ_UPDATE_CHANNEL@ from autoconf.
Attachment #666062 - Flags: review?(jones.chris.g)
Comment on attachment 666062 [details] [diff] [review]
updateChannel - v1

Does this default to something sane for local VARIANT=user builds?  r=me if so.
Attachment #666062 - Flags: review?(jones.chris.g) → review+
(In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> Does this default to something sane for local VARIANT=user builds?  r=me if
> so.

Yeah, B2G_UPDATE_CHANNEL always defaults to "nightly" when it isn't provided
Duplicate of this bug: 790351
https://hg.mozilla.org/mozilla-central/rev/777564a3cd50
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
(In reply to Marshall Culpepper [:marshall_law] from comment #4)
> (In reply to Chris Jones [:cjones] [:warhammer] from comment #3)
> > Does this default to something sane for local VARIANT=user builds?  r=me if
> > so.
> 
> Yeah, B2G_UPDATE_CHANNEL always defaults to "nightly" when it isn't provided

MOZ_UPDATE_CHANNEL defaults to "default", is this a different variable?
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #8)
> MOZ_UPDATE_CHANNEL defaults to "default", is this a different variable?

See my pull request, our build system should be defaulting to nightly when the updater is enabled:

https://github.com/mozilla-b2g/gonk-misc/pull/36/files
Ouch, that calls for problems or at least unexpected stuff as it means that self-compiled builds of developers will try to update to our official builds.
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #10)
> Ouch, that calls for problems or at least unexpected stuff as it means that
> self-compiled builds of developers will try to update to our official builds.

By default, developer builds have the updater disabled, so it I don't think that should be a problem.
(In reply to Marshall Culpepper [:marshall_law] from comment #11)
> By default, developer builds have the updater disabled, so it I don't think
> that should be a problem.

Interesting, so this is another difference to Firefox then, where the updater is enabled by default. Still, I also worry that if that would be there in the long run, we might get crash reports from random developer builds mixed with the official builds (if crashreporter is enabled in developer builds, which it is not with Firefox what no idea what you guys build against by default). But then, I'm pretty sure that using the "nightly" channel for unofficial build won't hold up when builds move to releng anyhow, and we won't get useful crash reports until some time after we have done that move.
You need to log in before you can comment on or make changes to this bug.