795516 - Enable Marionette tests on m-c and inbound

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jonathan Griffin (:jgriffin)]

Marionette tests on try are stable except for Win7 (bug 795513); let's turn them on for m-c and inbound except for Windows.  This will help us catch and prevent changes that break Marionette, such as that which happened with bug 793760.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Enable Marionette on m-c and inbound

Comment 2

[Phil Ringnalda (:philor)]

Are you planning on doing it like Jetpack does, non-tier-1 tests that are hidden but you personally can see when bustage landed, or was "m-c and inbound" a typo for "every trunk-based tree"?

Comment 3

[Jonathan Griffin (:jgriffin)]

(In reply to Phil Ringnalda (:philor) from comment #2)
> Are you planning on doing it like Jetpack does, non-tier-1 tests that are
> hidden but you personally can see when bustage landed, or was "m-c and
> inbound" a typo for "every trunk-based tree"?

The former until we can verify things are running smoothly, then we'll switch to the latter.

Comment 4

[Chris AtLee [:catlee]]

Comment on attachment 666109 [details] [diff] [review]
Enable Marionette on m-c and inbound

Review of attachment 666109 [details] [diff] [review]:
-----------------------------------------------------------------

::: mozilla-tests/config.py
@@ +1079,5 @@
>              # this is just for desktop Firefox
>              continue
> +        config_file = "marionette/prod_config.py"
> +        if pf.startswith('win'):
> +            if branch is not 'try':

using "is" to test string equality is a bad idea in python. please use != instead.

>>> a = "mozilla-central"
>>> b = "mozilla-central"
>>> a is b
False
>>> a == b
True

Comment 5

[Jonathan Griffin (:jgriffin)]

(In reply to Chris AtLee [:catlee] from comment #4)
> Comment on attachment 666109 [details] [diff] [review]
> Enable Marionette on m-c and inbound
> 
> Review of attachment 666109 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mozilla-tests/config.py
> @@ +1079,5 @@
> >              # this is just for desktop Firefox
> >              continue
> > +        config_file = "marionette/prod_config.py"
> > +        if pf.startswith('win'):
> > +            if branch is not 'try':
> 
> using "is" to test string equality is a bad idea in python. please use !=
> instead.
> 
Oops, good catch.

Landed as http://hg.mozilla.org/build/buildbot-configs/rev/6387cc3767bc.

Comment 6

[Rail Aliiev [:rail]]

in production http://hg.mozilla.org/build/buildbot-configs/rev/1b567f980831

Comment 7

[Rail Aliiev [:rail]]

Failing:

/tools/buildbot/bin/python scripts/scripts/marionette.py --cfg marionette/prod_config.py
 in dir /builds/slave/talos-slave/test/. (timeout 1200 secs) (maxTime 3600 secs)
 watching logfiles {}
 argv: ['/tools/buildbot/bin/python', 'scripts/scripts/marionette.py', '--cfg', 'marionette/prod_config.py']
 environment:
  Apple_PubSub_Socket_Render=/tmp/launch-OI3H6G/Render
  Apple_Ubiquity_Message=/tmp/launch-yLXv9I/Apple_Ubiquity_Message
  HOME=/Users/cltbld
  LOGNAME=cltbld
  PATH=/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin
  PROPERTIES_FILE=/builds/slave/talos-slave/test/buildprops.json
  PWD=/builds/slave/talos-slave/test
  SHELL=/bin/bash
  SSH_AUTH_SOCK=/tmp/launch-VkvkOj/Listeners
  TMPDIR=/var/folders/xx/59ykv66n1hj3nt4n04tr9sh400000w/T/
  USER=cltbld
  VERSIONER_PYTHON_PREFER_32_BIT=no
  VERSIONER_PYTHON_VERSION=2.7
  __CF_USER_TEXT_ENCODING=0x1C:0:0
 using PTY: False
Traceback (most recent call last):
  File "scripts/scripts/marionette.py", line 244, in <module>
    marionetteTest = MarionetteTest()
  File "scripts/scripts/marionette.py", line 115, in __init__
    'require_test_zip': True,})
  File "/builds/slave/talos-slave/test/scripts/mozharness/base/script.py", line 634, in __init__
    self.new_log_obj(default_log_level=default_log_level)
  File "/builds/slave/talos-slave/test/scripts/mozharness/base/script.py", line 761, in new_log_obj
    dirs = self.query_abs_dirs()
  File "scripts/scripts/marionette.py", line 145, in query_abs_dirs
    dirs['abs_work_dir'], 'gecko')
KeyError: 'abs_work_dir'
program finished with exit code 1
elapsedTime=0.292439

Comment 8

[Rail Aliiev [:rail]]

Actually it's http://hg.mozilla.org/build/mozharness/rev/192ee18cb135 and bug 789652

Comment 9

[Jonathan Griffin (:jgriffin)]

(In reply to Rail Aliiev [:rail] from comment #7)
> Failing:
> 
> KeyError: 'abs_work_dir'
> program finished with exit code 1
> elapsedTime=0.292439

Fixed with http://hg.mozilla.org/build/mozharness/rev/75cc8200e032