79555 - Offline: Download/Sync Now doesn't retain Mail or News checkmarks

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P1)

Description

[laurel]

Using may08 commercial trunk build

The Download/Sync Now dialog doesn't retain user's checkmark for Mail or News
messages after each use.  I don't think we spec'd this, but 4.x retains the
checkmark across sessions. If I'm a regular offline user, I wouldn't want to
have to re-enable this box eack time.

1.  Already logged into IMAP mail account, in mail window.
2.  File|Download/Sync Now.
3.  Choose select, check that a mail folder is selected.
4.  Checkmark/enable the "Mail Messages" checkbox.
5.  OK the Download/Sync Now dialog --> it finishes whatever download options
you'd set. Dialog closes.
6.  File|Download/Sync Now.  Notice the "Mail Messages" checkbox is disabled now.

Result:  Checkmark for Mail Messages or News Messages (for scope of download) is
not retained after download completion.

Comment 1

[jglick]

Agree, it should remember the users previous settings.

Comment 2

[Diane Sun]

We need preference  settings set up from the backend,  only after the backend 
adds those preference in  for Mail, News, Unsent Msg &  workoffline.  We can 
modify the UI to get the settings saved.

Comment 3

[David :Bienvenu]

Diane, the js code can get and set preferences directly, as we've discussed
previously. - you don't need any backend changes.

Comment 4

[scottputterman]

nominating

Comment 5

[grylchan]

Also noticed with 2001050804 build in the same Download/Sync Now
window that 
 - if you uncheck 'send unsent messages', it will still be checked
   the next time you bring up the Download/Sync Now window
 - if you check 'Work offline once download/sync is complete' it 
   isn't retained the next time you bring up the Download/Sync Now window
    
I'm assuming this is the same problem as the other 2 prefs in
in the Download/Sync Now window

Comment 6

[Diane Sun]

Right,  they are the same.  No preference has ever been set for these 4 
checkboxes.

Comment 7

[Diane Sun]

Attachment: Add preference reading/saving

Comment 8

[David :Bienvenu]

r=bienvenu

Comment 9

[(not reading, please use [e-mail] instead)]

fix the while space issues, and sr=sspitzer

(use spaces, instead of tabs.)

Comment 10

[Marek Z. Jeziorek]

Setting target milestone to 0.9.2 (check it in anytime, even before, when the
tree is open for). Per PDT triage.

Comment 11

[Diane Sun]

Checking in mailnews/base/prefs/resources/content/am-offline.js;
/cvsroot/mozilla/mailnews/base/prefs/resources/content/am-offline.js,v  <--  am-
offline.js
new revision: 1.4; previous revision: 1.3
done
Checking in mailnews/base/resources/content/mailWindowOverlay.js;
/cvsroot/mozilla/mailnews/base/resources/content/mailWindowOverlay.js,v  <--  ma
ilWindowOverlay.js
new revision: 1.68; previous revision: 1.67
done
Checking in mailnews/base/resources/content/msgSynchronize.js;
/cvsroot/mozilla/mailnews/base/resources/content/msgSynchronize.js,v  <--  msgSy
nchronize.js
new revision: 1.2; previous revision: 1.1
done
Checking in modules/libpref/src/init/mailnews.js;
/cvsroot/mozilla/modules/libpref/src/init/mailnews.js,v  <--  mailnews.js
new revision: 3.109; previous revision: 3.108
done

Comment 12

[Diane Sun]

backup the checkin, reopen it.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

a=dbaron for trunk checkin (on behalf of drivers)

Comment 14

[Diane Sun]

fix checked in.

Comment 15

[grylchan]

Using the commercial trunk buids:
2001-06-12-09-trunk/ -win nt 4.0
2001-06-12-08-trunk/ mac os 9.0.4
2001-06-12-08-trunk/ linux 2.2, red hat 7.0

The follow prefs are retained in the Download/Sync window
regardless if you are setting them while online or offline:
-Mail Messages
-Newsgroup Messages
-Sent Unsent Messages
-Work offline once download and/or sync is complete

Note: if you are offline and you only select the "Work offline once download 
and/or sync is complete" pref and click ok, the window will not close until you 
uncheck the setting or select another preference (mail, news, or sent).

Marking as verified.