795630 - CapturePickerUI has an exception on Metro browser startup

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: General, defect)

Description

[Brian R. Bondy [:bbondy]]

CapturePickerUI has an exception on Metro browser startup
/browser/metro/base/content/browser-ui.js

  try {
    1.22          // XXX This is currently failing
    1.23 +        CapturePickerUI.init();
    1.24 +      } catch(ex) {
    1.25 +        Util.dumpLn("Exception in CapturePickerUI:", ex.message);
    1.26 +      }
    1.27 +

I'm  not sure what this is for, but please mark as metro-preview if it is important.

Comment 1

[Brian R. Bondy [:bbondy]]

(In reply to Jim Mathies [:jimm] from bug 795629 comment #3)
> I think this was used for screen captures on mobile devices. I think it'd be
> safe to remove CapturePickerUI.js, CaputureDialog.js, and
> chrome://browser/content/prompt/CaptureDialog.xul completely.

Comment 4

[Matt Brubeck (:mbrubeck)]

This code is actually used by form upload controls; it lets the user upload a photo or video directly from the camera instead of from the filesystem.

It looks like this is no longer implemented anywhere except in Metro code, so it should be safe to remove.  (I guess it's been superceded by getUserMedia?)
http://mxr.mozilla.org/mozilla-central/ident?i=nsICapturePicker

If so, we should also file a bug to remove the code from /layout/forms.

Comment 5

[Jim Mathies [:jimm]]

Attachment: patch

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 727610 [details] [diff] [review]
patch

remove capture picker related code.

Comment 7

[Matt Brubeck (:mbrubeck)]

Please remove these lines too:
http://hg.mozilla.org/mozilla-central/file/1d6fe70c79c5/browser/metro/components/components.manifest#l97

Comment 8

[Jim Mathies [:jimm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6adc6990dd8a

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6adc6990dd8a