795681 - mozunit doesn't output assert errors

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

mozunit does print out exceptions when they occur, but it doesn't do the same for asserts, which makes debugging errors uselessly difficuly.

Comment 1

[Mike Hommey [:glandium]]

Attachment: MozReview Request: Bug 795681 - Print out failures in mozunit runner. r=gps

Python's unittest separates errors and failures, where the former is
uncaught exceptions and the latter uncaught assertions. We were only
printing the former, making the mozunit runner output useless to debug
failures due to assertions in the code being tested.

I would usually edit the test to temporarily switch to unittest.main().
Enough is enough, handle failures properly.

At the same time, instead of printing all the errors one after the other
at the end, print them right after the TEST-UNEXPECTED-FAIL message.

Review commit: https://reviewboard.mozilla.org/r/34705/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/34705/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8718692 [details]
MozReview Request: Bug 795681 - Print out failures in mozunit runner. r=gps

https://reviewboard.mozilla.org/r/34705/#review31679

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/12b3f2e6e3e1

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/12b3f2e6e3e1