Last Comment Bug 795707 - Selecting multiple PGP/MIME encrypted messages crashes Thunderbird
: Selecting multiple PGP/MIME encrypted messages crashes Thunderbird
Status: RESOLVED FIXED
:
Product: MailNews Core
Classification: Components
Component: MIME (show other bugs)
: 16
: All All
: -- major (vote)
: Thunderbird 18.0
Assigned To: Patrick Brunschwig
:
:
Mentors:
Depends on:
Blocks: 768928
  Show dependency treegraph
 
Reported: 2012-09-30 07:28 PDT by Patrick Brunschwig
Modified: 2012-10-01 13:50 PDT (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed
fixed


Attachments
Patch v1 (2.45 KB, patch)
2012-09-30 07:28 PDT, Patrick Brunschwig
standard8: review+
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description Patrick Brunschwig 2012-09-30 07:28:42 PDT
Created attachment 666322 [details] [diff] [review]
Patch v1

The implementation of nsPgpMimeProxy.cpp assumes that there is only 1 instance of nsIPgpMimeProxy (and its corresponding JS object). However, this assumption is wrong, as can be shown by selecting multiple PGP/MIME messages.

The result is that Thunderbird crashes on all platforms if the JS Object is registered. The attached patch changes the single instance (service) type of nsIPgpMimeProxy to an object that is created individually for each message.
Comment 1 Mark Banner (:standard8) 2012-10-01 01:31:17 PDT
Comment on attachment 666322 [details] [diff] [review]
Patch v1

If you need this on TB 16, please request approval-comm-aurora and approval-comm-beta later today as we're likely to build the final beta today.
Comment 2 Patrick Brunschwig 2012-10-01 06:29:50 PDT
Comment on attachment 666322 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Regression caused by (bug #): 768928
User impact if declined: crashes Thunderbird if Enigmail installed
Testing completed (on c-c, etc.): comm-central, comm-aurora
Risk to taking this patch (and alternatives if risky): risk is low, changes are straight forward and have no side impact.
Comment 3 Mark Banner (:standard8) 2012-10-01 06:49:47 PDT
Checked in: https://hg.mozilla.org/comm-central/rev/3cb6fce9232d

Note You need to log in before you can comment on or make changes to this bug.