795707 - Selecting multiple PGP/MIME encrypted messages crashes Thunderbird

Status: RESOLVED FIXED

(MailNews Core :: MIME, defect)

Description

[Patrick Brunschwig]

Attachment: Patch v1

The implementation of nsPgpMimeProxy.cpp assumes that there is only 1 instance of nsIPgpMimeProxy (and its corresponding JS object). However, this assumption is wrong, as can be shown by selecting multiple PGP/MIME messages.

The result is that Thunderbird crashes on all platforms if the JS Object is registered. The attached patch changes the single instance (service) type of nsIPgpMimeProxy to an object that is created individually for each message.

Comment 1

[Mark Banner (:standard8)]

Comment on attachment 666322 [details] [diff] [review]
Patch v1

If you need this on TB 16, please request approval-comm-aurora and approval-comm-beta later today as we're likely to build the final beta today.

Comment 2

[Patrick Brunschwig]

Comment on attachment 666322 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Regression caused by (bug #): 768928
User impact if declined: crashes Thunderbird if Enigmail installed
Testing completed (on c-c, etc.): comm-central, comm-aurora
Risk to taking this patch (and alternatives if risky): risk is low, changes are straight forward and have no side impact.

Comment 3

[Mark Banner (:standard8)]

Checked in: https://hg.mozilla.org/comm-central/rev/3cb6fce9232d

Comment 4

[Mark Banner (:standard8)]

Checked in:

https://hg.mozilla.org/releases/comm-aurora/rev/1c32536d12f3
https://hg.mozilla.org/releases/comm-beta/rev/e53b1c5df7f1