Created attachment 666322 [details] [diff] [review] Patch v1 The implementation of nsPgpMimeProxy.cpp assumes that there is only 1 instance of nsIPgpMimeProxy (and its corresponding JS object). However, this assumption is wrong, as can be shown by selecting multiple PGP/MIME messages. The result is that Thunderbird crashes on all platforms if the JS Object is registered. The attached patch changes the single instance (service) type of nsIPgpMimeProxy to an object that is created individually for each message.
Comment on attachment 666322 [details] [diff] [review] Patch v1 If you need this on TB 16, please request approval-comm-aurora and approval-comm-beta later today as we're likely to build the final beta today.
Attachment #666322 - Flags: review?(mbanner) → review+
Comment on attachment 666322 [details] [diff] [review] Patch v1 [Approval Request Comment] Regression caused by (bug #): 768928 User impact if declined: crashes Thunderbird if Enigmail installed Testing completed (on c-c, etc.): comm-central, comm-aurora Risk to taking this patch (and alternatives if risky): risk is low, changes are straight forward and have no side impact.
Assignee: nobody → patrick
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
status-thunderbird16: --- → fixed
status-thunderbird17: --- → fixed
You need to log in before you can comment on or make changes to this bug.