Remove hardcoded comma before introTextKeys and make it localizable

RESOLVED FIXED in Firefox 22

Status

RESOLVED FIXED
6 years ago
7 months ago

People

(Reporter: Tonnes, Assigned: Tonnes)

Tracking

unspecified
Firefox 22

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
When opening the Developer Toolbar for the first time, en-US Firefox says the following:

* For a list of commands type >>Help, or to show/hide command hints press…

Apparently the [comma whitespace] part following ‘Help’ has been hardcoded, making it unwantedly appear in our and maybe other locales. E.g. for nl this currently appears as

* Typ >>Help , voor een lijst met opdrachten of druk op…

It would be nice to either have a new localizable string for this part, or (easier) just have the current ‘comma whitespace combo’ moved to the beginning of introTextKeys, so locales can use them there if needed. See mxr.mozilla.org/mozilla-aurora/source/browser/devtools/commandline/gcli.jsm#6870.
(Assignee)

Comment 1

6 years ago
Created attachment 705881 [details] [diff] [review]
Move comma to introTextKeys

This might be all that is needed.
(Assignee)

Updated

6 years ago
Summary: Remove hardcoded ‘comma whitespace’ before introTextKeys and make it localizable → Remove hardcoded comma before introTextKeys and make it localizable
(Assignee)

Comment 2

6 years ago
Sorry to ask, but what would it take to get this done for v.next?
Comment on attachment 705881 [details] [diff] [review]
Move comma to introTextKeys

Review of attachment 705881 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.
I'll get this landed.
Attachment #705881 - Flags: review+
(In reply to Ton from comment #2)
> Sorry to ask, but what would it take to get this done for v.next?

Another time, a good way to get attention is to ask for a review from someone, but thanks for making the patch. Will land soon.
Whiteboard: [land-in-fxteam]
https://hg.mozilla.org/mozilla-central/rev/1ac8426837f5
Assignee: nobody → tonnes.mb
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 22
Thanks for your help getting this landed, Ton.
(Assignee)

Comment 9

6 years ago
Thanks for picking it up and fixing. :)

Updated

7 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.