Last Comment Bug 795723 - Remove hardcoded comma before introTextKeys and make it localizable
: Remove hardcoded comma before introTextKeys and make it localizable
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: unspecified
: All All
: -- normal (vote)
: Firefox 22
Assigned To: Ton
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-30 09:19 PDT by Ton
Modified: 2013-03-07 03:36 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Move comma to introTextKeys (1.85 KB, patch)
2013-01-24 08:30 PST, Ton
jwalker: review+
Details | Diff | Splinter Review

Description Ton 2012-09-30 09:19:27 PDT
When opening the Developer Toolbar for the first time, en-US Firefox says the following:

* For a list of commands type >>Help, or to show/hide command hints press…

Apparently the [comma whitespace] part following ‘Help’ has been hardcoded, making it unwantedly appear in our and maybe other locales. E.g. for nl this currently appears as

* Typ >>Help , voor een lijst met opdrachten of druk op…

It would be nice to either have a new localizable string for this part, or (easier) just have the current ‘comma whitespace combo’ moved to the beginning of introTextKeys, so locales can use them there if needed. See mxr.mozilla.org/mozilla-aurora/source/browser/devtools/commandline/gcli.jsm#6870.
Comment 1 Ton 2013-01-24 08:30:44 PST
Created attachment 705881 [details] [diff] [review]
Move comma to introTextKeys

This might be all that is needed.
Comment 2 Ton 2013-02-28 12:47:53 PST
Sorry to ask, but what would it take to get this done for v.next?
Comment 3 Joe Walker [:jwalker] (needinfo me or ping on irc) 2013-03-01 02:15:55 PST
Comment on attachment 705881 [details] [diff] [review]
Move comma to introTextKeys

Review of attachment 705881 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.
I'll get this landed.
Comment 4 Joe Walker [:jwalker] (needinfo me or ping on irc) 2013-03-01 02:17:33 PST
(In reply to Ton from comment #2)
> Sorry to ask, but what would it take to get this done for v.next?

Another time, a good way to get attention is to ask for a review from someone, but thanks for making the patch. Will land soon.
Comment 5 Joe Walker [:jwalker] (needinfo me or ping on irc) 2013-03-04 07:55:01 PST
https://tbpl.mozilla.org/?tree=Try&rev=089f57640fc8
Comment 7 Panos Astithas [:past] 2013-03-06 23:29:46 PST
https://hg.mozilla.org/mozilla-central/rev/1ac8426837f5
Comment 8 Joe Walker [:jwalker] (needinfo me or ping on irc) 2013-03-07 03:06:53 PST
Thanks for your help getting this landed, Ton.
Comment 9 Ton 2013-03-07 03:36:58 PST
Thanks for picking it up and fixing. :)

Note You need to log in before you can comment on or make changes to this bug.