795723 - Remove hardcoded comma before introTextKeys and make it localizable

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Ton [:Tonnes]]

When opening the Developer Toolbar for the first time, en-US Firefox says the following:

* For a list of commands type >>Help, or to show/hide command hints press…

Apparently the [comma whitespace] part following ‘Help’ has been hardcoded, making it unwantedly appear in our and maybe other locales. E.g. for nl this currently appears as

* Typ >>Help , voor een lijst met opdrachten of druk op…

It would be nice to either have a new localizable string for this part, or (easier) just have the current ‘comma whitespace combo’ moved to the beginning of introTextKeys, so locales can use them there if needed. See mxr.mozilla.org/mozilla-aurora/source/browser/devtools/commandline/gcli.jsm#6870.

Comment 1

[Ton [:Tonnes]]

Attachment: Move comma to introTextKeys

This might be all that is needed.

Comment 2

[Ton [:Tonnes]]

Sorry to ask, but what would it take to get this done for v.next?

Comment 3

[Joe Walker [:jwalker]]

Comment on attachment 705881 [details] [diff] [review]
Move comma to introTextKeys

Review of attachment 705881 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.
I'll get this landed.

Comment 4

[Joe Walker [:jwalker]]

(In reply to Ton from comment #2)
> Sorry to ask, but what would it take to get this done for v.next?

Another time, a good way to get attention is to ask for a review from someone, but thanks for making the patch. Will land soon.

Comment 5

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Try&rev=089f57640fc8

Comment 6

[Joe Walker [:jwalker]]

https://tbpl.mozilla.org/?tree=Fx-Team&rev=7eb5914cbb5d
https://hg.mozilla.org/integration/fx-team/rev/1ac8426837f5

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/mozilla-central/rev/1ac8426837f5

Comment 8

[Joe Walker [:jwalker]]

Thanks for your help getting this landed, Ton.

Comment 9

[Ton [:Tonnes]]

Thanks for picking it up and fixing. :)