Closed
Bug 795800
Opened 12 years ago
Closed 12 years ago
Intermittent test_addons_store.js | command timed out: 1200 seconds without output, attempting to kill
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla19
People
(Reporter: philor, Assigned: rnewman)
References
(Depends on 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(1 file, 3 obsolete files)
8.27 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
The telltale presence of three bugzilla searches in my autocomplete says it time to file it. Rev3 WINNT 5.1 services-central debug test xpcshell on 2012-09-30 19:20:34 PDT for push 4b4828e5a3f0 slave: talos-r3-xp-036 TEST-INFO | c:\talos-slave\test\build\xpcshell\tests\services\sync\tests\unit\test_addons_store.js | running test ... command timed out: 1200 seconds without output, attempting to kill
Reporter | ||
Comment 1•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16191815&tree=Services-Central
Reporter | ||
Comment 2•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16261217&tree=Services-Central
Reporter | ||
Comment 3•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16261327&tree=Services-Central
Reporter | ||
Comment 4•12 years ago
|
||
Oh, but look at that, they were all on s-c, and then s-c merged to m-c in and that merged to m-i, and now they are everywhere. https://tbpl.mozilla.org/php/getParsedLog.php?id=16362306&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=16367806&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=16365767&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=16152265&tree=Services-Central https://tbpl.mozilla.org/php/getParsedLog.php?id=15732081&tree=Services-Central https://tbpl.mozilla.org/php/getParsedLog.php?id=15580311&tree=Services-Central
Reporter | ||
Comment 5•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16367296&tree=Mozilla-Inbound
Reporter | ||
Comment 6•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16378733&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=16378063&tree=Mozilla-Inbound
Assignee | ||
Comment 7•12 years ago
|
||
Dammit XP. One of us will look at this today.
Reporter | ||
Comment 8•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16374878&tree=Mozilla-Inbound
Assignee | ||
Comment 9•12 years ago
|
||
We have no way to investigate this until we can see our xpcshell test log output in the log. Blocking on Bug 804648.
Depends on: 804648
Reporter | ||
Comment 10•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16383508&tree=Mozilla-Inbound
Reporter | ||
Comment 11•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16383648&tree=Mozilla-Inbound
Reporter | ||
Comment 12•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16385616&tree=Mozilla-Inbound
Reporter | ||
Comment 13•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16387031&tree=Firefox
Comment 14•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16389544&tree=Mozilla-Inbound
Reporter | ||
Comment 15•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16391868&tree=Mozilla-Inbound
Reporter | ||
Comment 16•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16392672&tree=Mozilla-Inbound
Reporter | ||
Comment 17•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16388534&tree=Birch
Reporter | ||
Comment 18•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16393633&tree=Mozilla-Inbound
Reporter | ||
Comment 19•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16397722&tree=Mozilla-Inbound
Reporter | ||
Comment 20•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16396761&tree=Mozilla-Inbound
Reporter | ||
Comment 21•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16397741&tree=Mozilla-Inbound
Reporter | ||
Comment 22•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16395060&tree=Mozilla-Inbound
Reporter | ||
Comment 23•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16399668&tree=Firefox
Reporter | ||
Comment 24•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16400358&tree=Mozilla-Inbound
Reporter | ||
Comment 25•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16404246&tree=Mozilla-Inbound
Reporter | ||
Comment 26•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16405336&tree=Mozilla-Inbound
Reporter | ||
Comment 27•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16407191&tree=Mozilla-Inbound
Reporter | ||
Comment 28•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16409352&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=16411340&tree=Mozilla-Inbound
Reporter | ||
Comment 29•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16414803&tree=Firefox https://tbpl.mozilla.org/php/getParsedLog.php?id=16412012&tree=Firefox
Reporter | ||
Comment 30•12 years ago
|
||
Run something that fails on slow slaves enough, eventually you'll find a Linux32 slave willing to fail. https://tbpl.mozilla.org/php/getParsedLog.php?id=16409203&tree=Profiling
OS: Windows XP → All
Hardware: x86 → All
Reporter | ||
Comment 31•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16428718&tree=Firefox
Reporter | ||
Comment 32•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16424682&tree=Profiling https://tbpl.mozilla.org/php/getParsedLog.php?id=16432616&tree=Profiling Hmm, interesting, no?
Reporter | ||
Comment 33•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16427152&tree=Birch
Assignee | ||
Comment 34•12 years ago
|
||
I moved all of the non-HTTP tests to the start of the file. Several then failed: they depended on state in AddonRepository, such as an add-on already installed with strict checking disabled, and thus no fetching or validation required. I added some overrides for those, and launched the HTTP server in one spot. The tests now pass on my machine.
Comment 35•12 years ago
|
||
Comment on attachment 674993 [details] [diff] [review] Proposed patch. v1 Review of attachment 674993 [details] [diff] [review]: ----------------------------------------------------------------- Hmmm. The introduction of ignoreRepositoryChecking = true everywhere worries me a bit. It was working before without that. Why? Could line 16 be throwing things off? I just want you to take one more look at it before I give r+.
Attachment #674993 -
Flags: review?(gps) → feedback+
Assignee | ||
Comment 36•12 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #35) > Hmmm. The introduction of ignoreRepositoryChecking = true everywhere worries > me a bit. It was working before without that. Why? My hypothesis: because the moved tests were previously running *after* other tests (which used ignoreRepositoryChecking) had fetched and stored the addons in the local AddonsRepository. > Could line 16 be throwing things off? > > I just want you to take one more look at it before I give r+. I'll take a look.
Reporter | ||
Comment 37•12 years ago
|
||
https://tbpl.mozilla.org/php/getParsedLog.php?id=16448686&tree=Birch https://tbpl.mozilla.org/php/getParsedLog.php?id=16448114&tree=Birch
Assignee | ||
Comment 38•12 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #35) > Hmmm. The introduction of ignoreRepositoryChecking = true everywhere worries > me a bit. It was working before without that. Why? > > Could line 16 be throwing things off? Removing that line (with this patch) allows all tests to pass. Presumably there was previously an ordering, such that that global pref applied to all the tests until that pref was first reset.
Assignee | ||
Comment 39•12 years ago
|
||
This version turns off checking globally. Note hacky "cleanup" test.
Attachment #674993 -
Attachment is obsolete: true
Attachment #675354 -
Flags: review?(gps)
Assignee | ||
Comment 40•12 years ago
|
||
… this version does the disabling on a per-test basis.
Attachment #675355 -
Flags: review?(gps)
Comment 41•12 years ago
|
||
Comment on attachment 675355 [details] [diff] [review] Option 2: local disabling. v1 Review of attachment 675355 [details] [diff] [review]: ----------------------------------------------------------------- ::: services/sync/tests/unit/test_addons_store.js @@ +27,5 @@ > + Svc.Prefs.set("addons.ignoreRepositoryChecking", true); > +} > + > +function clearRepositoryChecking() { > +} ??
Attachment #675355 -
Flags: review?(gps)
Assignee | ||
Comment 42•12 years ago
|
||
Cleaned.
Attachment #675355 -
Attachment is obsolete: true
Attachment #675364 -
Flags: review?(gps)
Updated•12 years ago
|
Attachment #675364 -
Flags: review?(gps) → review+
Assignee | ||
Updated•12 years ago
|
Attachment #675354 -
Attachment is obsolete: true
Attachment #675354 -
Flags: review?(gps)
Assignee | ||
Comment 43•12 years ago
|
||
Let's see if this helps. https://hg.mozilla.org/services/services-central/rev/2730a06e361e
Whiteboard: [orange] → [orange][fixed in services]
Assignee | ||
Comment 44•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2730a06e361e
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed in services] → [orange]
Target Milestone: --- → mozilla19
Updated•12 years ago
|
Keywords: intermittent-failure
Updated•12 years ago
|
Whiteboard: [orange]
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•