Closed Bug 795800 Opened 8 years ago Closed 8 years ago

Intermittent test_addons_store.js | command timed out: 1200 seconds without output, attempting to kill

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: philor, Assigned: rnewman)

References

(Depends on 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file, 3 obsolete files)

The telltale presence of three bugzilla searches in my autocomplete says it time to file it.

Rev3 WINNT 5.1 services-central debug test xpcshell on 2012-09-30 19:20:34 PDT for push 4b4828e5a3f0
slave: talos-r3-xp-036

TEST-INFO | c:\talos-slave\test\build\xpcshell\tests\services\sync\tests\unit\test_addons_store.js | running test ...

command timed out: 1200 seconds without output, attempting to kill
Dammit XP.

One of us will look at this today.
We have no way to investigate this until we can see our xpcshell test log output in the log. Blocking on Bug 804648.
Depends on: 804648
Blocks: 804673
Run something that fails on slow slaves enough, eventually you'll find a Linux32 slave willing to fail.

https://tbpl.mozilla.org/php/getParsedLog.php?id=16409203&tree=Profiling
OS: Windows XP → All
Hardware: x86 → All
Attached patch Proposed patch. v1 (obsolete) — Splinter Review
I moved all of the non-HTTP tests to the start of the file. Several then failed: they depended on state in AddonRepository, such as an add-on already installed with strict checking disabled, and thus no fetching or validation required.

I added some overrides for those, and launched the HTTP server in one spot.

The tests now pass on my machine.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #674993 - Flags: review?(gps)
Comment on attachment 674993 [details] [diff] [review]
Proposed patch. v1

Review of attachment 674993 [details] [diff] [review]:
-----------------------------------------------------------------

Hmmm. The introduction of ignoreRepositoryChecking = true everywhere worries me a bit. It was working before without that. Why?

Could line 16 be throwing things off?

I just want you to take one more look at it before I give r+.
Attachment #674993 - Flags: review?(gps) → feedback+
(In reply to Gregory Szorc [:gps] from comment #35)

> Hmmm. The introduction of ignoreRepositoryChecking = true everywhere worries
> me a bit. It was working before without that. Why?

My hypothesis: because the moved tests were previously running *after* other tests (which used ignoreRepositoryChecking) had fetched and stored the addons in the local AddonsRepository.

> Could line 16 be throwing things off?
> 
> I just want you to take one more look at it before I give r+.

I'll take a look.
(In reply to Gregory Szorc [:gps] from comment #35)

> Hmmm. The introduction of ignoreRepositoryChecking = true everywhere worries
> me a bit. It was working before without that. Why?
> 
> Could line 16 be throwing things off?

Removing that line (with this patch) allows all tests to pass.

Presumably there was previously an ordering, such that that global pref applied to all the tests until that pref was first reset.
Attached patch Option 1: global disabling. v1 (obsolete) — Splinter Review
This version turns off checking globally. Note hacky "cleanup" test.
Attachment #674993 - Attachment is obsolete: true
Attachment #675354 - Flags: review?(gps)
Attached patch Option 2: local disabling. v1 (obsolete) — Splinter Review
… this version does the disabling on a per-test basis.
Attachment #675355 - Flags: review?(gps)
Comment on attachment 675355 [details] [diff] [review]
Option 2: local disabling. v1

Review of attachment 675355 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/sync/tests/unit/test_addons_store.js
@@ +27,5 @@
> +  Svc.Prefs.set("addons.ignoreRepositoryChecking", true);
> +}
> +
> +function clearRepositoryChecking() {
> +}

??
Attachment #675355 - Flags: review?(gps)
Cleaned.
Attachment #675355 - Attachment is obsolete: true
Attachment #675364 - Flags: review?(gps)
Attachment #675364 - Flags: review?(gps) → review+
Attachment #675354 - Attachment is obsolete: true
Attachment #675354 - Flags: review?(gps)
Let's see if this helps.

https://hg.mozilla.org/services/services-central/rev/2730a06e361e
Whiteboard: [orange] → [orange][fixed in services]
https://hg.mozilla.org/mozilla-central/rev/2730a06e361e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed in services] → [orange]
Target Milestone: --- → mozilla19
Whiteboard: [orange]
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.