Closed Bug 795915 Opened 7 years ago Closed 7 years ago

Ensure permissions get encoded correctly in libmar test suite

Categories

(Toolkit :: Application Update, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla19

People

(Reporter: bbondy, Assigned: bbondy)

Details

Attachments

(1 file, 1 obsolete file)

This already works on our build servers, but if you clone m-c on Linux or OSX without changing any permissions it'll fail to encode the correct file permissions when running the libmar test_create.js test cases.
 
This patch will ensure that we always encode the same file permissions as the reference MAR.  Before this patch some users running this manually would get a getBinaryData compare error when running the libmar xpcshell tests.
Attached patch Patch v1. (obsolete) — Splinter Review
Had to spend a couple hours with a hex editor and refreshing myself on the MAR file format to see why the binary compare was failing.  This will ensure that doesn't happen again :)
Attachment #666563 - Flags: review?(robert.bugzilla)
Comment on attachment 666563 [details] [diff] [review]
Patch v1.

Please add a comment as to why 0644 is being used.
Attachment #666563 - Flags: review?(robert.bugzilla) → review+
Attached patch Patch v2Splinter Review
Increased the verbosity of the comments.  Carrying forward r+.
Attachment #666563 - Attachment is obsolete: true
Attachment #673316 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/ef967c3c6994
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.