Closed Bug 795915 Opened 7 years ago Closed 7 years ago
Ensure permissions get encoded correctly in libmar test suite
This already works on our build servers, but if you clone m-c on Linux or OSX without changing any permissions it'll fail to encode the correct file permissions when running the libmar test_create.js test cases. This patch will ensure that we always encode the same file permissions as the reference MAR. Before this patch some users running this manually would get a getBinaryData compare error when running the libmar xpcshell tests.
Had to spend a couple hours with a hex editor and refreshing myself on the MAR file format to see why the binary compare was failing. This will ensure that doesn't happen again :)
Attachment #666563 - Flags: review?(robert.bugzilla)
Comment on attachment 666563 [details] [diff] [review] Patch v1. Please add a comment as to why 0644 is being used.
Attachment #666563 - Flags: review?(robert.bugzilla) → review+
Increased the verbosity of the comments. Carrying forward r+.
Target Milestone: --- → mozilla19
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.