Intermittent testAllPagesTab | all pages list has 5 children (the default bookmarks) - got 2, expected 5

RESOLVED FIXED in Firefox 20

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: emorley, Assigned: gbrown)

Tracking

({intermittent-failure})

Trunk
Firefox 20
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Android Armv6 Tegra 250 mozilla-inbound opt test robocop on 2012-10-01 02:37:55 PDT for push 64236acfaa80

slave: tegra-119

https://tbpl.mozilla.org/php/getParsedLog.php?id=15698059&tree=Mozilla-Inbound

{
1 INFO TEST-START | testAllPagesTab
2 INFO TEST-PASS | testAllPagesTab | Awesomebar URL typed properly - http://mochi.test:8888/tests/robocop/robocop_big_link.html should equal http://mochi.test:8888/tests/robocop/robocop_big_link.html
3 INFO TEST-PASS | testAllPagesTab | checking that all pages list exists - android.widget.ListView@443e1a28
4 INFO TEST-UNEXPECTED-FAIL | testAllPagesTab | all pages list has 5 children (the default bookmarks) - got 2, expected 5
Exception caught during test!
junit.framework.AssertionFailedError: 4 INFO TEST-UNEXPECTED-FAIL | testAllPagesTab | all pages list has 5 children (the default bookmarks) - got 2, expected 5
	at junit.framework.Assert.fail(Assert.java:47)
	at org.mozilla.fennec.FennecMochitestAssert._logMochitestResult(FennecMochitestAssert.java:107)
	at org.mozilla.fennec.FennecMochitestAssert.ok(FennecMochitestAssert.java:136)
	at org.mozilla.fennec.FennecMochitestAssert.is(FennecMochitestAssert.java:142)
	at org.mozilla.fennec.tests.testAllPagesTab.testList(testAllPagesTab.java:61)
	at org.mozilla.fennec.tests.testAllPagesTab.testAllPagesTab(testAllPagesTab.java:50)
	at java.lang.reflect.Method.invokeNative(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:521)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:204)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:194)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:186)
	at org.mozilla.fennec.tests.BaseTest.runTest(BaseTest.java:95)
	at junit.framework.TestCase.runBare(TestCase.java:127)
	at junit.framework.TestResult$1.protect(TestResult.java:106)
	at junit.framework.TestResult.runProtected(TestResult.java:124)
	at junit.framework.TestResult.run(TestResult.java:109)
	at junit.framework.TestCase.run(TestCase.java:118)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:169)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:154)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:520)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1447)
5 INFO TEST-UNEXPECTED-FAIL | testAllPagesTab | Exception caught - junit.framework.AssertionFailedError: 4 INFO TEST-UNEXPECTED-FAIL | testAllPagesTab | all pages list has 5 children (the default bookmarks) - got 2, expected 5
}
Whiteboard: [orange]
I took a screenshot from a tegra running testAllPagesTab, just after waitForText("http://mochi.test:8888/tests/robocop/robocop_big_link.html"), at https://hg.mozilla.org/mozilla-central/annotate/21195f52311c/mobile/android/base/tests/testAllPagesTab.java.in#l62.

Looking at the screenshot, it occurs to me that the text we are waiting for is certainly displayed before we start waiting -- in the awesomebar! Maybe it would be better to wait for the page title text?
Passing around a title like "Big Link" as well as the url seemed prone to error. Checking for the first bookmark url is simple and ought to work just as well.

I don't know if this will fix the intermittent failure, but it seems like an improvement.
Assignee: nobody → gbrown
Attachment #694133 - Flags: review?(wjohnston)
Comment on attachment 694133 [details] [diff] [review]
wait for first bookmark instead of entered url

I agree. Its possible (likely even) that this url is showing the urlbar, leaving to false positives.
Attachment #694133 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/54c6c42eb219
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
You need to log in before you can comment on or make changes to this bug.