The default bug view has changed. See this FAQ.

Typing "@gmail.com" as part of the username shouldn't be required when setting up a gtalk account

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Instant Messaging
--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 18.0
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird17 fixed)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Guessing if the domain is @gmail.com or @googlemail.com is possible if we implement a Google specific XMPP extension documented at https://developers.google.com/talk/jep_extensions/jid_domain_change

I think we should do it to avoid some confusion.
(Assignee)

Comment 1

5 years ago
Created attachment 666597 [details] [diff] [review]
Patch

This patch works only if bug 786684 is fixed.
Assignee: nobody → florian
Attachment #666597 - Flags: review?(clokep)
(Assignee)

Updated

5 years ago
Depends on: 786684
Comment on attachment 666597 [details] [diff] [review]
Patch

The code looks good, but I think I'd like a comment above PlainFullBindAuth pointing to the link you provide in this bug and a comment above the "if (!this._jid.node) {" block describing what is happening in this situation.
Attachment #666597 - Flags: review?(clokep) → review-
Also, the corresponding Instantbird bug: https://bugzilla.instantbird.org/show_bug.cgi?id=1535
(Assignee)

Comment 4

5 years ago
Created attachment 666947 [details] [diff] [review]
Patch v2

Same patch with more comments.
Attachment #666597 - Attachment is obsolete: true
Attachment #666947 - Flags: review?(clokep)
Comment on attachment 666947 [details] [diff] [review]
Patch v2

Excellent. Thanks for fixing this!
Attachment #666947 - Flags: review?(clokep) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/comm-central/rev/b176895f1b15
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
(Assignee)

Comment 7

5 years ago
http://hg.instantbird.org/instantbird/rev/c90d46307450
(Assignee)

Comment 8

5 years ago
Comment on attachment 666947 [details] [diff] [review]
Patch v2

[Approval Request Comment]
If we take this patch, users won't have to type @gmail.com any more when configuring Google Talk account (ie less possible ways to mis configure a Google Talk account).
Attachment #666947 - Flags: approval-comm-aurora?
Attachment #666947 - Flags: approval-comm-aurora? → approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/583b589da03e
status-thunderbird17: --- → fixed
(Assignee)

Updated

5 years ago
Depends on: 806079
You need to log in before you can comment on or make changes to this bug.