using lowercase locales in url leads to 404

VERIFIED FIXED

Status

--
minor
VERIFIED FIXED
6 years ago
5 years ago

People

(Reporter: retornam, Assigned: kohei)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [kb=1259185] , URL)

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
STR:
1) Visit http://www.mozilla.org/en-us/firefox/new/ 
2) It redirects to  http://www.mozilla.org/en-US/en-us/firefox/new/


If my memory serves me right lowercase locales redirected t the correct pages.
(Reporter)

Updated

6 years ago
Severity: normal → critical
no, it never did, I don't mind if it does although I am not sure it is very useful.
and resetting to minor since we never had this feature.
Severity: critical → minor
(Assignee)

Updated

5 years ago
Blocks: 879544
(Assignee)

Updated

5 years ago
OS: Mac OS X → All
Hardware: x86 → All
(Assignee)

Comment 3

5 years ago
Created attachment 8369145 [details] [review]
Pull Request on GitHub
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
(Assignee)

Updated

5 years ago
Whiteboard: [kb=1259185]
(Reporter)

Comment 4

5 years ago
Cmore or Gareth,
We need more information on the number of users  who hit 404 pages when they use lowercase letters for locales. It looks like this bug happens on a few locales only
Flags: needinfo?(garethcull.bugs)
Flags: needinfo?(chrismore.bugzilla)
I'll take a look at this...
Flags: needinfo?(garethcull.bugs)
(Reporter)

Comment 6

5 years ago
(In reply to Gareth Cull [:garethc] from comment #5)
> I'll take a look at this...

Thanks Gareth.
Flags: needinfo?(chrismore.bugzilla)
I believe I've figured this one out. The URLs that are having the issue are in global.conf and are being passed through to bedrock but only for en-US. e.g....

https://github.com/mozilla/bedrock/blob/master/etc/httpd/global.conf#L182

This rule is case sensitive, so it's not forwarding requests to /en-us/firefox/new/ to bedrock. We can fix this either by making these rules case insensitive, or going with :kohei's patch. My vote is for the latter, so I'll start testing it to make sure it really fixes the issue.

Thanks again :kohei
(Assignee)

Comment 8

5 years ago
Thanks :pmac for the investigation!

Comment 9

5 years ago
Good investigation!

Comment 10

5 years ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/fd16dc8c0e118978b61659f93330c18310c87ce5
Fix Bug 795970 - using lowercase locales in url leads to 404

https://github.com/mozilla/bedrock/commit/202cbbfd2e897017c644517fcd507f7133b5585a
Merge pull request #1652 from kyoshino/bug-795970-lowercase-locales

Fix Bug 795970 - using lowercase locales in url leads to 404

Updated

5 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Comment 11

5 years ago
fixed lowercase en-us for example goes to https://www.allizom.org/en-US/firefox/new/
(Reporter)

Updated

5 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.