JavaScript strict warning: logger.js, line 453: assignment to undeclared variable entry

RESOLVED FIXED in Thunderbird 18.0

Status

Thunderbird
Instant Messaging
--
trivial
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: aceman)

Tracking

Trunk
Thunderbird 18.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1007 bytes, patch
aceman
: review+
Details | Diff | Splinter Review
JavaScript strict warning: file:///Users/florian/buildhg/comm-central/obj-tbird-dbg/mozilla/dist/DailyDebug.app/Contents/MacOS/components/logger.js, line 453: assignment to undeclared variable entry

http://hg.mozilla.org/comm-central/annotate/3cb6fce9232d/chat/components/src/logger.js#l453
(Assignee)

Comment 1

5 years ago
Change it to 'for each (let entry in aEntries)'.
(In reply to :aceman from comment #1)
> Change it to 'for each (let entry in aEntries)'.

Sure. I was just hoping someone was going to attach a patch so that I can r+ it ;).
(Assignee)

Comment 3

5 years ago
Will do :)
Assignee: nobody → acelists
(Assignee)

Comment 4

5 years ago
Created attachment 667052 [details] [diff] [review]
patch
Attachment #667052 - Flags: review?(florian)
(Assignee)

Updated

5 years ago
Status: NEW → ASSIGNED
Comment on attachment 667052 [details] [diff] [review]
patch

This looks good, thanks aceman. :)
Attachment #667052 - Flags: review?(florian) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

5 years ago
Created attachment 667056 [details] [diff] [review]
patch v2
Attachment #667052 - Attachment is obsolete: true
Attachment #667056 - Flags: review+
https://hg.mozilla.org/comm-central/rev/1dc2c3e736e9
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
http://hg.instantbird.org/instantbird/rev/5d86f7e7b3b1
You need to log in before you can comment on or make changes to this bug.