Closed Bug 795971 Opened 9 years ago Closed 9 years ago

JavaScript strict warning: logger.js, line 453: assignment to undeclared variable entry

Categories

(Thunderbird :: Instant Messaging, defect)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 18.0

People

(Reporter: florian, Assigned: aceman)

References

Details

Attachments

(1 file, 1 obsolete file)

1007 bytes, patch
aceman
: review+
Details | Diff | Splinter Review
JavaScript strict warning: file:///Users/florian/buildhg/comm-central/obj-tbird-dbg/mozilla/dist/DailyDebug.app/Contents/MacOS/components/logger.js, line 453: assignment to undeclared variable entry

http://hg.mozilla.org/comm-central/annotate/3cb6fce9232d/chat/components/src/logger.js#l453
Change it to 'for each (let entry in aEntries)'.
(In reply to :aceman from comment #1)
> Change it to 'for each (let entry in aEntries)'.

Sure. I was just hoping someone was going to attach a patch so that I can r+ it ;).
Will do :)
Assignee: nobody → acelists
Attached patch patch (obsolete) — Splinter Review
Attachment #667052 - Flags: review?(florian)
Status: NEW → ASSIGNED
Comment on attachment 667052 [details] [diff] [review]
patch

This looks good, thanks aceman. :)
Attachment #667052 - Flags: review?(florian) → review+
Keywords: checkin-needed
Attached patch patch v2Splinter Review
Attachment #667052 - Attachment is obsolete: true
Attachment #667056 - Flags: review+
https://hg.mozilla.org/comm-central/rev/1dc2c3e736e9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 18.0
You need to log in before you can comment on or make changes to this bug.