Last Comment Bug 795971 - JavaScript strict warning: logger.js, line 453: assignment to undeclared variable entry
: JavaScript strict warning: logger.js, line 453: assignment to undeclared vari...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Instant Messaging (show other bugs)
: Trunk
: All All
: -- trivial (vote)
: Thunderbird 18.0
Assigned To: :aceman
:
Mentors:
Depends on:
Blocks: 787149
  Show dependency treegraph
 
Reported: 2012-10-01 10:08 PDT by Florian Quèze [:florian] [:flo]
Modified: 2012-10-05 03:16 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (1008 bytes, patch)
2012-10-02 10:43 PDT, :aceman
clokep: review+
Details | Diff | Splinter Review
patch v2 (1007 bytes, patch)
2012-10-02 10:54 PDT, :aceman
acelists: review+
Details | Diff | Splinter Review

Description Florian Quèze [:florian] [:flo] 2012-10-01 10:08:54 PDT
JavaScript strict warning: file:///Users/florian/buildhg/comm-central/obj-tbird-dbg/mozilla/dist/DailyDebug.app/Contents/MacOS/components/logger.js, line 453: assignment to undeclared variable entry

http://hg.mozilla.org/comm-central/annotate/3cb6fce9232d/chat/components/src/logger.js#l453
Comment 1 :aceman 2012-10-02 01:10:26 PDT
Change it to 'for each (let entry in aEntries)'.
Comment 2 Florian Quèze [:florian] [:flo] 2012-10-02 02:01:42 PDT
(In reply to :aceman from comment #1)
> Change it to 'for each (let entry in aEntries)'.

Sure. I was just hoping someone was going to attach a patch so that I can r+ it ;).
Comment 3 :aceman 2012-10-02 02:55:21 PDT
Will do :)
Comment 4 :aceman 2012-10-02 10:43:00 PDT
Created attachment 667052 [details] [diff] [review]
patch
Comment 5 Patrick Cloke [:clokep] 2012-10-02 10:44:58 PDT
Comment on attachment 667052 [details] [diff] [review]
patch

This looks good, thanks aceman. :)
Comment 6 :aceman 2012-10-02 10:54:40 PDT
Created attachment 667056 [details] [diff] [review]
patch v2
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-10-02 16:02:07 PDT
https://hg.mozilla.org/comm-central/rev/1dc2c3e736e9
Comment 8 Florian Quèze [:florian] [:flo] 2012-10-05 03:16:58 PDT
http://hg.instantbird.org/instantbird/rev/5d86f7e7b3b1

Note You need to log in before you can comment on or make changes to this bug.