795991 - moz-do-not-send is set to true with undiscoverable img src url, preventing images from being included in forwards of html messages

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[johnson]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_6_8) AppleWebKit/537.4 (KHTML, like Gecko) Chrome/22.0.1229.79 Safari/537.4

Steps to reproduce:

I get an HTML-formatted mail message, forward it on to others


Actual results:

No images show up in the forwarded message, because moz-do-not-send is set to true, but the img src in the resulting html message is inaccessible to anyone but the original sender, since it's referring to an IMAP message source:

<img moz-do-not-send="true" 
                    id="Picture_x0020_1" 
src="imap://<username>@imap.pharmacy.arizona.edu:143/fetch%3EUID%3E/INBOX%3E45295?header=quotebody/;section=2?part=1.2&amp;filename=image001.png" 
                    alt="Description: Description: 
                    cid:image003.png@01CD965A.0D1EFC90" height="672" 
                    width="480">

NO other user will ever be able to see this image.


Expected results:

moz-do-not-send="true" should ONLY ever be set for uri's that are publicly reachable: http, https.

Comment 1

[Joe Sabash [:JoeS1]]

Reporter, (I dislike calling people by their last name)
Could you supply a sample message via File>>save as>>eml and attach it here.
The image source should look like:
<img alt="" src="cid:[e-mail]"
        height="28" width="28">
The image should have been converted to a CID as above.

Comment 2

[johnson]

Attachment: Sample email

this was forwarded as an attachment, forwarding inline behaves the same way.

Comment 3

[johnson]

(In reply to Joe Sabash from comment #1)
> Reporter, (I dislike calling people by their last name)

My name's Bruce

Comment 4

[johnson]

Attachment: This is a sample email with 'send attachments inline' set

Comment 5

[Joe Sabash [:JoeS1]]

Attachment: original message

To that end, I tried to simulate the original message and forwarded it several times from my newly created gmail imap account. I was unable to reproduce.

Just to be clear, you were able to view the image on the original mail, but lost it on a forwarded copy. Right?
What happens when you forward, is that the image is retrived again from the server before the forward is actually sent.

I'll attach my simulation eml. Does it look like the original? (different image of course)

Comment 6

[Joe Sabash [:JoeS1]]

Lost a little text on the above comment:
Attempting to get a reproducible test case.

Comment 7

[johnson]

I see the image in your simulation, but, crucially, the image IS included as an attachment in yours, but not the originals we're having problems with. 

Also, in your simulation, the img src uri is:

img moz-do-not-send="false" id="Picture_x0020_1" src="cid:[e-mail]"

'moz-do-not-send' is false, and the source is the attached gif.

In ours the uri is

<img moz-do-not-send="true" id="Picture_x0020_1" src="imap://[e-mail]:143/fetch%3EUID%3E/INBOX%3E45295?header=quotebody/;section=2?part=1.2&amp;filename=image001.png" 

Note 'moz-do-not-send' is true, and the image source is a reference intoto the sender's imap account.

Note, this is not the first time I've witnessed this behavior over the years, but it is the first time it's reached the level of the Dean of the college complaining about it :-)

Comment 8

[Joe Sabash [:JoeS1]]

Under Account settings Synchronization & Storage...what is checked under Disk Space

Comment 9

[johnson]

Attachment: SYnchronization and storage

These are the default settings, under advanced all mailboxes are chosen.

Comment 10

[Joe Sabash [:JoeS1]]

To make any headway here, there must be a reproducible testcase.
The samples show that msword was used to compose the message.

Was copy/paste used in the composition window?
Insert>>html?
If insert>>image was used the checkbox "attach this image to the message" directly controls if -moz-do-not-send is applied.

Comment 11

[johnson]

I'll have to investigate. The person forwarding the email had received it from someone else, and was forwarding it on to others; I'll see if I can find the original sender.

Comment 12

[johnson]

The message came from an outside organization, I can attach the original source. (minus the 433k image attachment) . It was sent via a Microsoft SMTP server and mentions MAPI so it may have been sent directly from Word.

I've been unable to reproduce this problem locally, either, so we may have to wait until it happens again or just doesn't happen again...:-/

Let me know if you want the original source.

Comment 13

[Joe Sabash [:JoeS1]]

msword does a pretty poor job of html composition. (a lot of unnecessary tags)

But sure go ahead and post that original source.

Comment 14

[johnson]

Attachment: Original email that was forwarded

This came form an outside organization, I've included the attachment. Don't see anything out of the ordinary...

Comment 15

[Joe Sabash [:JoeS1]]

I forwarded that original message several times with no problem.
So I will mark this worksforme.

Bruce, Thanks for taking the time to file the bug (we can always reopen if further issues arise)

I make it a point to support organizations that use Thunderbird.
Don't hesitate to file bugs as you see them.