Closed Bug 796086 Opened 7 years ago Closed 7 years ago

protect against Obj-C exceptions in widget/cocoa/nsLookAndFeel

Categories

(Core :: Widget, defect, major)

x86
macOS
defect
Not set
major

Tracking

()

RESOLVED FIXED
mozilla18

People

(Reporter: Irving, Assigned: Irving)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #417558 +++

For implementing the strategy we decided on in bug 163260 we are filing a bug for each top-level directory that needs work.


Since bug 415778 was committed it appears that new Objective-C calls have been added that lack Obj-C exception handling; this is showing in Thunderbird 15.0.1 topcrashers, bug 790229 and possibly bug 790232 (the stack is probably invalid in the latter).
OK if I take this?
Assignee: nobody → irving
Sure, no need to ask if it isn't already assigned to someone.
Added ObjC exception macros around two recently added methods.
Attachment #667086 - Flags: review?(smichaud)
Comment on attachment 667086 [details] [diff] [review]
Add Obj-C try/catch macros around recently added methods

This looks OK -- at least it shouldn't do any harm.

But I wonder if it'll really help with bug 790229.  Time will tell, guess.
Attachment #667086 - Flags: review?(smichaud) → review+
https://hg.mozilla.org/mozilla-central/rev/00398627cfef
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.