Closed
Bug 796163
Opened 12 years ago
Closed 12 years ago
[Contacts] Import contacts from SIM - no error message on failure
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)
Tracking
(blocking-basecamp:+)
People
(Reporter: benfrancis, Assigned: arcturus)
Details
(Whiteboard: interaction, UX-P2)
Attachments
(2 files)
I tried to import contacts from my SIM card. There were no errors and it appeared to complete the operation, but no contacts were imported.
It could be that Android didn't store any contacts on my SIM or it could be that there was an error and the import failed. Either way it didn't inform me.
I can't find UX specs for this feature so I don't know what it's expected to do.
Reporter | ||
Comment 1•12 years ago
|
||
Built on: 2012-10-01
Gecko: 80b40bba7f30f6cea5cb148cbbdcbf008691972b
Gaia: bd9b9654155b8e3b39928f16d24673f6ced72b6f
Comment 2•12 years ago
|
||
Blocking because the user cannot know for sure if zero contacts were found or if there was an error.
blocking-basecamp: ? → +
Comment 3•12 years ago
|
||
The platform should provide all the needed functionality here. If no contacts are stored on the SIM card we get the success callback with 0 contacts and if something went wrong we should get informed by the error callback.
Assignee | ||
Comment 4•12 years ago
|
||
Right now the frontend is listening to both events, error and success, so I guess that we need from the support from the backend that Gregor comments.
Comment 5•12 years ago
|
||
I think we should add some notification if there are no contacts on the sim card. We still call the success callback but the length of imported contacts is 0.
The user has no way to see that the import finished. Could we add a notification that tells the user how many contacts were imported?
Assignee: nobody → fbsc
Updated•12 years ago
|
Priority: -- → P3
Updated•12 years ago
|
Assignee: fbsc → chris.varga.job
Updated•12 years ago
|
Priority: P3 → --
Updated•12 years ago
|
blocking-basecamp: + → -
![]() |
||
Updated•12 years ago
|
Whiteboard: [bug] → [bug][qa+]
Updated•12 years ago
|
Component: Gaia → Gaia::Contacts
Updated•12 years ago
|
Priority: -- → P2
Whiteboard: [bug][qa+] → [bug][qa+] Interaction design
Comment 6•12 years ago
|
||
Renoming because of critical importance of SIM card management to target market release.
blocking-basecamp: - → ?
Priority: P2 → --
Whiteboard: [bug][qa+] Interaction design → interaction, UX-P2
Comment 7•12 years ago
|
||
Francisco, what is current status on this issue? I think part of this bug was already addresssed.
Flags: needinfo?(francisco.jordano)
Assignee | ||
Comment 8•12 years ago
|
||
So far we show the error message when the import is going ok, but we have 0 contacts on the SIM.
Fix should be pretty straight forward.
Thanks.
Flags: needinfo?(francisco.jordano)
Comment 9•12 years ago
|
||
I asked Ayman about the feedback when no contacts in the SIM and his answer was: "Resuming that we do not know before the user selects 'import from SIM' that there are no contacts on the SIM card: If the SIM card is inserted but there is no contacts in the SIM, when the "Import from SIM" button is pressed the message shown should be: "No contacts detected in SIM to import".
Updated•12 years ago
|
blocking-basecamp: ? → +
Priority: -- → P3
Assignee | ||
Updated•12 years ago
|
Assignee: chris.varga.job → francisco.jordano
Comment 10•12 years ago
|
||
(In reply to Maria Angeles Oteo from comment #9)
> I asked Ayman about the feedback when no contacts in the SIM and his answer
> was: "Resuming that we do not know before the user selects 'import from SIM'
> that there are no contacts on the SIM card: If the SIM card is inserted but
> there is no contacts in the SIM, when the "Import from SIM" button is
> pressed the message shown should be: "No contacts detected in SIM to import".
its 'Presuming' not 'Resuming'. you missed the 'P' when you did the copy / paste ;)
Assignee | ||
Comment 11•12 years ago
|
||
Attachment #688713 -
Flags: review?(stas)
Attachment #688713 -
Flags: review?(alberto.pastor)
Comment 12•12 years ago
|
||
Comment on attachment 688713 [details]
Pointer to GitHub PR 6822
r-
This is a significant change in meaning, so let's bump the revision here, to `simContacts-imported3` (on all seven strings).
This way the localizers will get notified of the change and will have a chane to update their translations.
Thanks!
Attachment #688713 -
Flags: review?(stas) → review-
Comment 13•12 years ago
|
||
Mass Modify: All un-milestoned, unresolved blocking-basecamp+ bugs are being moved into the C3 milestone. Note that the target milestone does not mean that these bugs can't be resolved prior to 12/10, rather C2 bugs should be prioritized ahead of C3 bugs.
Target Milestone: --- → B2G C3 (12dec-1jan)
Updated•12 years ago
|
Attachment #688713 -
Flags: review?(alberto.pastor) → review+
Assignee | ||
Comment 14•12 years ago
|
||
Comment on attachment 688713 [details]
Pointer to GitHub PR 6822
New version in github, wigh :stas comments added.
Also pinging :Pike for late l10n as long as Stas is on holidays.
Alberto I had to modify the js to adjust to the new string, can you recheck?
Attachment #688713 -
Flags: review- → review?(l10n)
Comment 15•12 years ago
|
||
Comment on attachment 688713 [details]
Pointer to GitHub PR 6822
quoting my github comment:
Stas asked for all 7 to be replaced, and not just one?
Also, I just checked with Matej, we should rather say "on SIM" than "in SIM"
Attachment #688713 -
Flags: review?(l10n) → review-
Assignee | ||
Comment 16•12 years ago
|
||
Hi Axel,
he asked so far for the new string we were adding/modifying.
About put 'on SIM' rather than 'in SIM' is ok for me, just copy pasted from Comment 9 so it's not a big deal to change it.
Thanks a lot!
Assignee | ||
Comment 17•12 years ago
|
||
Comment on attachment 688713 [details]
Pointer to GitHub PR 6822
Changed,
thanks.
Attachment #688713 -
Flags: review- → review?
Comment 18•12 years ago
|
||
To quote stas:
(In reply to Staś Małolepszy :stas (offline Dec 7-Dec 16) from comment #12)
>
> This is a significant change in meaning, so let's bump the revision here, to
> `simContacts-imported3` (on all seven strings).
on all seven strings.
Updated•12 years ago
|
Attachment #688713 -
Flags: review? → review-
Assignee | ||
Comment 19•12 years ago
|
||
Comment on attachment 688713 [details]
Pointer to GitHub PR 6822
Fingers crossed this one is the good one
Attachment #688713 -
Flags: review- → review?
Assignee | ||
Updated•12 years ago
|
Attachment #688713 -
Flags: review? → review?(l10n)
Updated•12 years ago
|
Attachment #688713 -
Flags: review?(l10n) → review+
Assignee | ||
Comment 20•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 21•12 years ago
|
||
We should use the "Banner" building block to notify the user about the result of the action, in this case importing contacts from the SIM.
IN the attached screenshot you will see the message at the bottom of the screen, that will automatically disappear. In case there's no contacts to import in the SIM, the banner will appear showing something like "No contacts found"
You need to log in
before you can comment on or make changes to this bug.
Description
•