796194 - [Calendar] Swiping does not escape from tray.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Ben Francis [:benfrancis]]

STR:
* Open calendar app
* Click button top left to open side tray
* Try to close side tray by touching or swiping UI on the right

Expected:
* Tray disappears

Actual:
* Trapped in the side tray until someone comes to let me out, or I figure out that I need to press the little button again.

I'm not sure if this is actually in the UX spec, but this is how the side tray works in the browser app and I would expect it to be consistent.

Josh: Is this in the UX specs for all apps with a side tray do you know?

Built on: 2012-10-01
Gecko: 80b40bba7f30f6cea5cb148cbbdcbf008691972b
Gaia: bd9b9654155b8e3b39928f16d24673f6ced72b6f

Comment 1

[Josh Carpenter [:jcarpenter]]

It sounds like tapping button works, but swiping does not?

If so, this is a known issue which I believe (but am not sure) may be solved by applying building blocks, or simply reusing code (expertly crafted, I'm told) from Browser.

Comment 2

[Josh Carpenter [:jcarpenter]]

cc'ing Casey

Comment 3

[Alex Keybl [:akeybl]]

[mass adding reproducible keyword for any open Gaia bug with the word "STR:" in comments]

Comment 4

[James Lal [:lightsofapollo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/5674

Pointer to Github pull-request

Comment 5

[John Hammink]

Otoro daily: 10-11-2012
* gaia: 2667536e3b06e46dd193aa6d76ba08dad2d867be
* gonk: 6ec34aa3d66331054de37eabc594ad923654b27c

Currently this still doesn't work as described in the STR:  Swiping UI on the right has no effect, but actually touching the calendar UI on the right restores it.

Should swiping the UI on the right (to restore calendar) work?

Comment 6

[Casey Yee]

This should work in the same way that the Browser tabs works.

To open: The user can open the drawer by tapping on the drawer button.

To close: To close the drawer, the user can tap on the drawer button or any of the area which the main app is showing.   The user should also be able to drag or swipe the drawer close.

We should be implementing this at a Building Blocks level so that we can be consistent with the drawer behavior across all the applications that use it.

Comment 7

[Josh Carpenter [:jcarpenter]]

+1

Comment 8

[James Lal [:lightsofapollo]]

OK, since this has improved a bit I renamed this issue. 
If building blocks can really solve the whole problem, great and no work should be required here. If not after we solve the remainder of blocking issues this should be fixed for consistency with the rest of the apps.

Comment 9

[Ben Francis [:benfrancis]]

I don't think this is very easy to create a building block for, it's not so much a UI element in its own right as a design pattern. The implementation is likely to be quite different for each app.

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Just to make a note, I believe that the main issue is that the touch event is getting eaten by the calendar month being moved to the next month on the swipe.

The swipe action requires that you do touch the calendar if you are swiping the calendar closed.  (comparing it to the browser tab drawer close)

Comment 11

[BMO Automation]

Firefox OS is not being worked on