796196 - configuration.py should keep track of all variables added via the add method

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

def add is used to update the configuration:

http://hg.mozilla.org/build/talos/file/16fc2d57416d/talos/configuration.py#l375

This should keep track of all variables added to the configuration so
that implementations.

Comment 1

[Jeff Hammel]

configuration.py actually lives here: http://k0s.org/mozilla/hg/configuration/

So the fix should be made against that and ported to talos.  We initially decided to just copy configuration.py to talos, though now i'm wondering if that was a wise decision...

Comment 2

[Jeff Hammel]

http://k0s.org/mozilla/hg/configuration/rev/9d19ed8fd883

Comment 3

[Johannes Vogel (:nebelhom)]

As this blocks the bug I was previously working on, do you reckon I have enough know-how to handle this myself? I'd like to do it as it kinda helps me to get to know more parts of the machinery.

However, you didn't mark it as a "good first bug" and I have no illusions here. If you think a beginner like me would c*ck this up or take up too much of your time, then just let me know. I'll contact you some time today or tomorrow in IRC.

Thanks

Comment 4

[Jeff Hammel]

(In reply to nebelhom from comment #3)
> As this blocks the bug I was previously working on, do you reckon I have
> enough know-how to handle this myself? I'd like to do it as it kinda helps
> me to get to know more parts of the machinery.
> 
> However, you didn't mark it as a "good first bug" and I have no illusions
> here. If you think a beginner like me would c*ck this up or take up too much
> of your time, then just let me know. I'll contact you some time today or
> tomorrow in IRC.
> 
> Thanks

I mostly didn't mark it as a good first bug as most of the bug will be mirroring -> talos and testing on talos, as well as the fact that configuration.py lives upstream.  The actual "fun" was done in http://k0s.org/mozilla/hg/configuration/rev/9d19ed8fd883 . I'll do the mirroring and testing shortly

Comment 5

[Jeff Hammel]

Attachment: upgrade to modern configuration.py which has this fix

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 667102 [details] [diff] [review]
upgrade to modern configuration.py which has this fix

Review of attachment 667102 [details] [diff] [review]:
-----------------------------------------------------------------

from what I can tell this looks good.

Comment 7

[Jeff Hammel]

pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=2f50133597d7

Comment 8

[Jeff Hammel]

green, pushing to talos: http://hg.mozilla.org/build/talos/rev/7d1383f80c37

Comment 9

[Mozilla RelEng Bot]

Try run for 2f50133597d7 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=2f50133597d7
Results (out of 69 total builds):
    success: 69
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-2f50133597d7