Closed Bug 796228 Opened 12 years ago Closed 12 years ago

B2G Test Drivers feedback app bugs

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: lsblakk, Assigned: yurenju)

References

Details

Just tested the Feedback app on today's build and first of all, thank you for this initial effort - the build ID comes through and that is really helpful. Also, it currently uses the wrong URL to submit (http instead of https) but when I changed the URL and loaded it up again I was able to submit a comment, so that is great.

The following needs work before this can be used by our testers:

* Change the URL to https://b2gtestdrivers.allizom.org/comments
* The app requires network access to work properly so we either need to:
** Check for network on startup and state clearly to the user that the app cannot work without network access (instead of failing *after* they've taken time to input feedback)
OR
** Save the feedback and submit later when there is network (perhaps the next time the app is opened?)

* After submitting feedback the app goes to the https://b2gtestdrivers.allizom.org/comments page showing the comment was submitted and there is no way to get back to the app's clean comment submission interface, the app should reset itself after submission and be ready for another comment

* It does appear to hang on to the comment asset tag setting, but it is editable and that's not ideal - it could get accidentally or intentionally reset/altered
** Let's have a first run screen that asks for contact info/asset tag and then never show that screen again (just hang on to the info and put it in the form submissions)

* This app should be on the very first page of apps on the homescreen for easy discoverability

Thanks again for the work so far, a few more tweaks and this should be more useful and robust for our 400 testers who are about to be let loose on this product.
After talking about this with Josh - a couple of things:

1.  Perhaps Kevin Hu can help us with this as him and his team are working more on Gaia apps - this is likely a very small piece of work and we really appreciate a Gaia dev's time on this

2. Instead of moving it to a different screen, Josh says it's possible we could put it in the dock - so if this could be in the dock as a 5th dock icon (by default) while we are in the internal testing period (pre-v1.0 release) that would be ideal
Assignee: 21 → khu
Feedback app should be implemented by Vivien. 
https://github.com/mozilla-b2g/gaia/commits/master/apps/feedback
Assigned to Vivien.
Assignee: khu → 21
Hey Yruen, can you look into Feedback app a bit and see how much effort it takes for you to complete the above task? If it's OK I think you can take it :)
OK, I can take it, and can I post some test data to https://b2gtestdrivers.allizom.org/comments ?
Assignee: 21 → yurenju
(In reply to Yuren Ju [:yurenju] from comment #4)
> OK, I can take it, and can I post some test data to
> https://b2gtestdrivers.allizom.org/comments ?

Yup, I can delete test data when it's time to go live so please post away - email me if you need to be able to see the data posted or if you want anything to change about the response once posted.
One more nit: instead of "Reset" and "Done" buttons in the top right corner, we should just have a  "Submit" button.

The flow should look like this:

* First time the app is opened - a field to enter either asset tag or email address
* Once entered and submitted, the view should be a text box saying "Please share any feedback with us. What's working? What's not?"  and there is a "Submit" button
* Submitting text data sends that data (asset_tag, buildID, comment) to https://b2gtestdrivers.allizom.org/comments
* The user is returned to the text box & submit button view so they can submit a new comment whenever they like
Thanks for opening the bug, a lot of things as unclear to me. This is helpful that you can try it and see what's missing. 

But we are feature frozen and we need to shipt the software with the resource we have. Let's not spend too much time on doing 'shiny' thing, let's have something functional and that's good enough for this now.


(In reply to Lukas Blakk [:lsblakk] from comment #0)
> Just tested the Feedback app on today's build and first of all, thank you
> for this initial effort - the build ID comes through and that is really
> helpful. Also, it currently uses the wrong URL to submit (http instead of
> https) but when I changed the URL and loaded it up again I was able to
> submit a comment, so that is great.
> 
> The following needs work before this can be used by our testers:
> 
> * Change the URL to https://b2gtestdrivers.allizom.org/comments

Done.

> * The app requires network access to work properly so we either need to:
> ** Check for network on startup and state clearly to the user that the app
> cannot work without network access (instead of failing *after* they've taken
> time to input feedback)
> OR
> ** Save the feedback and submit later when there is network (perhaps the
> next time the app is opened?)
> 

I don't think it worth spending time on that on our side.  I will disabled the 'Done' button if the device is offline and enabled it when the device comes online.


> * After submitting feedback the app goes to the
> https://b2gtestdrivers.allizom.org/comments page showing the comment was
> submitted and there is no way to get back to the app's clean comment
> submission interface, the app should reset itself after submission and be
> ready for another comment

Done.

> * It does appear to hang on to the comment asset tag setting, but it is
> editable and that's not ideal - it could get accidentally or intentionally
> reset/altered
> ** Let's have a first run screen that asks for contact info/asset tag and
> then never show that screen again (just hang on to the info and put it in
> the form submissions)
> 

It does not seems a blocker to me. I would let you do it and don't spend resource on that.
It's also unclear on what's wrong with beeing able to edit it? What if you did a mistake the first time?


> * This app should be on the very first page of apps on the homescreen for
> easy discoverability
> 

Done (move to the dock as suggested).


I did a PR here https://github.com/mozilla-b2g/gaia/pull/5634 . I think the editable asset field question can be discussed into a different bug and we should not spend too much time on that on the Gaia team side.
Thank you for the fast work Vivien - I look forward to testing out this new version.  To be clear - this is not a feature (and thus, not subject to feature-freeze), it's a pre-release Feedback channel and it's very important to driving improvements on Gaia as we sprint to v1.0 but this app is not being shipped with the final code.
I have landed Gaia's PR. Closing as resolved fixed and please open a new bug (with blocking-basecamp?) if there is still some needs.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Blocks: 800679
This works as comment 7 claims, I have filed bug 800679 for a couple of additional requests.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.