796246 - it should not be possible to enable passcode lock while lock screen not enabled

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[GH to BZ]

[GitHub issue by dbaron on 2012-09-06T00:35:24Z, https://github.com/mozilla-b2g/gaia/issues/4384]
Right now it's possible to enable passcode lock while the lock screen is not enabled.  (in Settings -> Phone Lock)

Doing this causes the phone, when it's off and the power button is pressed, to wait 5-10 seconds before coming back to life.  This is a very surprising behavior.

It's not clear to me what should happen here, and the easiest thing seems to me for the passcode lock option to be disabled and off when the lock screen isn't enabled at all.  (Either that, or not have the lock screen option at all.)

gaia revision = 370c8378

Comment 1

[GH to BZ]

[GitHub comment by autonome on 2012-09-17T23:13:30Z]
There's a workaround, so not holding the V1 release for this.

The settings UI change sounds like a reasonable approach.

Comment 2

[Les Orchard [:lorchard]]

Going to try taking this on as a first-time Gaia hacker

Comment 3

[Les Orchard [:lorchard]]

https://github.com/mozilla-b2g/gaia/pull/5906

Comment 4

[Evelyn Hung]

r+, merged and let Vivien know this.

Comment 5

[sarsenyev]

Reviewed and verified 
on build ID:20121231070201
Device -"Unagi"
OS -"Gonk"

Comment 6

[Swarnava Sengupta (:Swarnava)]

I can still reproduce this issue on latest stable build on Geeksphone keon