796263 - [BB][Clock] Use settings' style checkboxes for alarms [switches]

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P3)

Description

[GH to BZ]

[GitHub issue by stasm on 2012-09-25T20:10:07Z, https://github.com/mozilla-b2g/gaia/issues/5164]
In the Clock app in the list of alarms, instead of ON and OFF labels which are hard to localize due to the space limitation, could we employ the approach from the settings app? A blue tick and the knob the right means 'on', greyed-out empty space and the knob to the left means 'off'.

Comment 1

[GH to BZ]

[GitHub comment by ian-liu on 2012-10-01T04:13:26Z]
@stasm 
Good catch! We have discussed the issue with @fabi1cazenave and @PeterLa .

@PeterLa @patrykdesign 
Is the final style confirmed? (the style shown in the clock or the one in the common controls sheet)
After decided the style, please re-assign the issue to me.
I'll refine it.

Comment 2

[Peter La]

@ian-liu

As discussed in our email thread, @fabilcazenave is implementing the final on/off control in the building blocks.  Please check with him and use the building block in the clock app.

Thanks!

Peter

Comment 3

[[e-mail], [e-mail]]

(In reply to Peter La from comment #2)
> @ian-liu
> 
> As discussed in our email thread, @fabilcazenave is implementing the final
> on/off control in the building blocks.  Please check with him and use the
> building block in the clock app.
> 
> Thanks!
> 
> Peter
Hi Peter,

Thanks for your confirmation.
I'll take care the issue with @fabilcazenave.

Comment 4

[Patryk Adamczyk [:patryk] UX]

Can we updated the check boxes with the tweaked design.

Comment 5

[Ismael Gonzalez [:basiclines]]

I will take care on implementing the switches.css as soon as https://bugzilla.mozilla.org/show_bug.cgi?id=807006 lands.

Comment 6

[Ismael Gonzalez [:basiclines]]

Attachment: PR

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 7

[[e-mail], [e-mail]]

Comment on attachment 678806 [details]
PR

It works for me.
Thanks for your help.
r+

Comment 8

[Ismael Gonzalez [:basiclines]]

Merged: https://github.com/mozilla-b2g/gaia/commit/a28f1a61305a399d3ffa482d6a973ace3cbdbb32

Comment 9

[Staś Małolepszy :stas]

Are the text labels ('ON' and 'OFF') still needed, or can we remove them?

If they're needed (e.g. for accessibility), please put a comment in clock.en-US.properties to explain that translations of these labels don't need to fit in the UI visually.

If they're not needed, please remove them from clock.en-US.properties entirely as part of this bug.

Comment 10

[[e-mail], [e-mail]]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6306

Pointer to Github pull-request

Comment 11

[[e-mail], [e-mail]]

Comment on attachment 679957 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6306

Remove useless tag and text labels.

Comment 12

[Ismael Gonzalez [:basiclines]]

Comment on attachment 679957 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6306

Looking good!

Comment 13

[[e-mail], [e-mail]]

Merged https://github.com/mozilla-b2g/gaia/pull/6306

Hi Stas,
I removed the text labels ('ON' and 'OFF').
Thanks for your reminder.

Comment 14

[Staś Małolepszy :stas]

Thanks as well, Ian!

Comment 15

[Rebecca Billings [:rbillings]]

Verified on the 11/26 unagi build.