Closed
Bug 796308
Opened 12 years ago
Closed 11 years ago
List DIviding Line Length - Music App
Categories
(Firefox OS Graveyard :: Gaia::Music, defect, P3)
Firefox OS Graveyard
Gaia::Music
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ghtobz, Assigned: dkuo)
Details
(Whiteboard: visual design, incorrect implementation)
[GitHub issue by authoritaire on 2012-09-25T10:56:34Z, https://github.com/mozilla-b2g/gaia/issues/5134] For @PeterLa and @patrykdesign. Hey guys, As discussed with patryk before I went away ( but the bug was never posted) Music app needs consistent dividing line length in lists. Currently have 3 different styles in same app. The three styles are highlighted below: Music_List_Album_View_120720.jpg - gap on left, not on right ( should have gaps on either side) Music_List_Albums_G_Full_Search_120720.jpg - correct design just check it has correct line length. Music_List_Playlists_A_120720.jpg - Line goes right across ( should have gaps on either side) All list dividers should not go to the edge on either side ( excluding headers and footers). Gap should be 15 pixel each side. This consistent style was only confirmed just before I went away. Any questions about specific sizes please check with @sergivila or myself. cheers steve
[GitHub comment by patrykdesign on 2012-09-26T12:32:46Z] @dominickuo can you please look at @authoritaire comments and make the adjusts. Thanks.
Updated•12 years ago
|
Priority: -- → P3
Comment 2•12 years ago
|
||
Currently the app doesn't have any divider lines.
Updated•12 years ago
|
Whiteboard: [label:music][label:needsVISUALinput] → visual design, incorrect implementation
Updated•12 years ago
|
Component: Gaia → Gaia::Music
Assignee | ||
Comment 3•12 years ago
|
||
I have made some changes on playlist, artist, album and song lists in https://github.com/mozilla-b2g/gaia/pull/6535 Patryk, can you see if I am doing right? thanks.
Assignee | ||
Comment 4•12 years ago
|
||
Note that for the song list style, there is no duration (time) but the space is reserved. I need to modify the metadata parser then we can get the time, and fill it in the space. That will be another patch for sure.
Assignee | ||
Comment 5•11 years ago
|
||
This issue is fixed since the list are applied to the latest styles, so closing this. The only thing left is the duration is still missing, but already filed in bug 826650.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•