796311 - [music] music scans every time the app becomes visible.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P3)

Description

[GH to BZ]

[GitHub issue by nhirata on 2012-09-26T21:31:46Z, https://github.com/mozilla-b2g/gaia/issues/5257]
## Environment :
Otoro phone, build 2012-09-26 us
Taken from default.xml in b2g-distro: 
* "platform_build" revision= 795261940c8b11fb7dddd7a8e9dd8561fdc4fb64
* "gaia" revision= 34bcd071074c4b5802195fd9173bd108e6c5891c 
* "releases-mozilla-central" revision= 35d92aa2a19da7aa89cffd7508d7d2ea40d40bc7
* "gonk-misc" revision= 1fa95341cd2bbf5d476cbcf84d03c33cd5fe66fc
  
## Repro :
1. launch music
2. play a song
3. hit power button
4. tap power button to wake
5. unlock device

## Expected :
1. music app should be there without any scanning dialog

## Actual :
1. scanning dialog appears briefly

## Note :
1. also occurs when you place the app in the background and bring it back in the foreground.
2. regression from bug #4533
3. does not occur for video, does not seem to occur for gallery

Comment 1

[GH to BZ]

[GitHub comment by autonome on 2012-09-28T07:50:08Z]
@dominickuo does that pr fix this issue? If so, please close this one. Thanks!

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

@dominickuo please see comment 1.

Comment 3

[Dominic Kuo [:dkuo]]

Already fixed by
https://github.com/mozilla-b2g/gaia/pull/5338
Thanks, Tim.

Comment 4

[John Hammink]

Otoro daily: 10-11-2012
* gaia: 2667536e3b06e46dd193aa6d76ba08dad2d867be
* gonk: 6ec34aa3d66331054de37eabc594ad923654b27c

Now music application reappears without any scanning dialog.  

However music keeps playing after power button has been hit (device "sleeps").  This is confusing.  Is it supposed to work like this?

When application is placed in the background (I launched calculator), music does stop playing, even though the music app is still up.   And once the music app is again in focus (used task switcher), scanning reoccurs - and the song left playing before is no longer playing or in focus.

Marking this "reopened" because apparently the problem still exists - and the behavior of each case is very unclear.  Please advise.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to John Hammink from comment #4)
> Otoro daily: 10-11-2012
> * gaia: 2667536e3b06e46dd193aa6d76ba08dad2d867be
> * gonk: 6ec34aa3d66331054de37eabc594ad923654b27c
> 
> Now music application reappears without any scanning dialog.  

According to STR in comment 0 that means this bug is fixed right?

> However music keeps playing after power button has been hit (device
> "sleeps").  This is confusing.  Is it supposed to work like this?

I don't know. This should be something related to how wake lock works.

> When application is placed in the background (I launched calculator), music
> does stop playing, even though the music app is still up.   And once the
> music app is again in focus (used task switcher), scanning reoccurs - and
> the song left playing before is no longer playing or in focus.
> 
> Marking this "reopened" because apparently the problem still exists - and
> the behavior of each case is very unclear.  Please advise.

I suspect the behaviour you experienced is because Music app crashed on background. Music is not supposed to stop playing when the app is switching to background.

But I would say anything below deserve and should go to other bugs. Please file those and mark this as fixed.

Comment 6

[Dominic Kuo [:dkuo]]

(In reply to John Hammink from comment #4)
> Otoro daily: 10-11-2012
> * gaia: 2667536e3b06e46dd193aa6d76ba08dad2d867be
> * gonk: 6ec34aa3d66331054de37eabc594ad923654b27c
> 
> Now music application reappears without any scanning dialog.  
> 
> However music keeps playing after power button has been hit (device
> "sleeps").  This is confusing.  Is it supposed to work like this?
> 

Yes, if a user hits the power button, it dose not imply that the device should "sleeps", maybe the user just want to turn off the screen for saving some battery, but still want listen to music. So we will not stop playing music after power button has been hit.

> When application is placed in the background (I launched calculator), music
> does stop playing, even though the music app is still up.   And once the
> music app is again in focus (used task switcher), scanning reoccurs - and
> the song left playing before is no longer playing or in focus.
> 

Music does play when it's placed in the background, currently we don't have any handles for this. if it stop playing, that should be a crash of Music. So I will say it's a "re-launch" when Music is focus again, can you still reproduce this using recently build?

> Marking this "reopened" because apparently the problem still exists - and
> the behavior of each case is very unclear.  Please advise.

Comment 7

[Dominic Kuo [:dkuo]]

Hey John, what's the status of your verification? can you still reproduce this using recently build?

Comment 8

[Dietrich Ayala (:dietrich)]

Closing, since I no longer see this in today's build. Per comment #5, please file other bugs for unrelated issues.