796326 - [STK] needs Dialer app to observe an outgoing call placed by STK

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Github issue by hsinyi: https://github.com/mozilla-b2g/gaia/issues/5394

With support by STK, a user can make an outgoing call from STK app, even when dialer app is closed.
Dialer needs to be able to observe an outgoing call placed by STK, and then process the call as usual. So a user can handle the call via dialer.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This feature is needed by STK.
Dialer app needs to receive system message from Bug 795235.

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Bug 795232 is about to land. The gaia support is needed for testing in Brazil this week. Could you help this issue, etienne?  Thanks!

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2)
> Bug 795232 is about to land. The gaia support is needed for testing 
  ^^^^^^^^^^  should be Bug 795235.

> in Brazil this week. Could you help this issue, etienne?  Thanks!

Comment 4

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/pull/5655

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

r+ on https://github.com/mozilla-b2g/gaia/pull/5655#issuecomment-9108343

Comment 6

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/pull/5655

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Etienne, this works on the second try. I mean:

1.- Boot B2G
2.- Open a STK app
3.- Select a phone call option

(issue: No dialer started)

4.- Opens again the same STK app
5.- Select the same option

(now the dialer is opened)

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Fernando, can you provide the log for the issue you said?

There might be cause by other problems.
Can you paste your bug with ril_const.js DEBUG_ALL is on?

Thank you.

Comment 9

[Etienne Segonzac (:etienne)]

(In reply to Fernando R. Sela from comment #7)
> Etienne, this works on the second try. I mean:
> 
> 1.- Boot B2G
> 2.- Open a STK app
> 3.- Select a phone call option
> 
> (issue: No dialer started)
> 
> 4.- Opens again the same STK app
> 5.- Select the same option
> 
> (now the dialer is opened)

I can reproduce it. The dialer doesn't get the system message.
FYI the telephony-incoming system message works before the first launch of the Dialer, so it's something else.

Comment 10

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

I just see that the dialer app starts in background ... probably this is the main issue.

Comment 11

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Fernando R. Sela from comment #10)
> I just see that the dialer app starts in background ... probably this is the
> main issue.

I also noticed that. 
In my tests, dialer did receive "icc-dialing" message (I used "dump" for debugging), but no call screen popped out.

Comment 12

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: logcat

enabled "DEBUG_ALL" for RIL and SystemMessageInternal.js

You can see the system message was passed correctly from RIL to SystemMessageInternal to dialer.js, but the call screen wasn't launched.

Comment 13

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Fernando R. Sela from comment #10)
> I just see that the dialer app starts in background ... probably this is the
> main issue.

The dialer app starts in background, but it isn't binded to the stk call.

Comment 14

[Etienne Segonzac (:etienne)]

Mmmhhh... indeed the dialer *does* get the system message, sorry for the misdirection, looking at it.

Comment 15

[Etienne Segonzac (:etienne)]

Yep yep yep, totally my bad.
The call is already connected by the time the dialer is launched and we weren't handling this properly...

https://github.com/mozilla-b2g/gaia/pull/5678

Comment 16

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/pull/5678

Comment 17

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Etienne Segonzac (:etienne) from comment #15)
> Yep yep yep, totally my bad.
> The call is already connected by the time the dialer is launched and we
> weren't handling this properly...
> 
> https://github.com/mozilla-b2g/gaia/pull/5678
Yaya, thanks Etienne :D

Comment 18

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #17)
> (In reply to Etienne Segonzac (:etienne) from comment #15)
> > Yep yep yep, totally my bad.
> > The call is already connected by the time the dialer is launched and we
> > weren't handling this properly...
> > 
> > https://github.com/mozilla-b2g/gaia/pull/5678
> Yaya, thanks Etienne :D

Wow, I also noticed that this patch solves a problem that I encountered and I thought that resulted from my ongoing patches. 
Thanks again, Etienne :D

Comment 19

[austincmiller]

Device: Unagi 
Build ID: 20121231070201
Does not reproduce.