796392 - [Contacts] Performance when entering in search mode should be better

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P3)

Description

[GH to BZ]

[GitHub issue by albertopq on 2012-07-16T13:08:43Z, https://github.com/mozilla-b2g/gaia/issues/2456]
It seems that when you have more than 200 contacts, entering in search mode is quite slow.
Keyboard could be affecting as well.

Comment 1

[GH to BZ]

[GitHub comment by shianyow on 2012-07-20T07:34:19Z]
Is it what you see?

(1)Use the "UI test" APP to insert 500 testing contacts
(2)Go to launch the contact app
(3)It will cost about 6 seconds to see the contacts list.

Another issue is b2g process hanged after inserted 420 entries on otoro device, need to restart b2g process.

Comment 2

[GH to BZ]

[GitHub comment by albertopq on 2012-07-21T10:48:32Z]
@shianyow The issue you are talking about is when loading the contacts, and its performance is being improved.
Follow https://bugzilla.mozilla.org/show_bug.cgi?id=746439 for more info.

This issue is, once the contacts are loaded, entering in search mode.

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Entering and leaving search mode in Contacts with 400+ contacts from facebook takes more than 2 seconds.

Comment 4

[alberto.pastor]

We are using the same code for searching in both contacts and facebook import

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

Note this is not about searching but merely "entering" search mode. I think they are different issues but if we search empty string when entering search mode, that might explain the slowness.

Comment 6

[Jose Manuel Cantera]

Kan-ru is right. I think these are different issues and agree that entering into search mode takes ages but when search mode is entered no search is launched, thus, the problem might be in a possible reflow launched by changing a class name. 

I think we should keep separate this bug from bug 816742 which is close to land.

Comment 7

[Jose Manuel Cantera]

starting working on it. ETA Dec. 18th 2012

Comment 8

[Jose Manuel Cantera]

Attachment: Pointer to GH PR #7045

Comment 9

[Jose Manuel Cantera]

Francisco, I have heard Alberto is on vacation. That's why I have requested your review. If that is not the case I would ask Alberto. 

Ismael, there are many CSS changes, thus I would need also your review. 

Feedback from Cristian is also welcome as he has been working partly with me this morning.

thanks, best

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

JMC, yes, Alberto is on holidays, I'll take a look.

Thanks!

Comment 11

[Dietrich Ayala (:dietrich)]

Driver retriage: Partner data shows that ~100 is the average number of contacts for users. Blocking- on this bug for V1. Will definitely take this patch, just ask for approval. But not holding the whole release for a 500 contacts bug.

Comment 12

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 692968 [details]
Pointer to GH PR #7045

Definitely, if not a bb+, something to ask for master approval.

Don't have numbers with me, but in other projects related to fb, +100 friends was something common.

Cheers!
F.

Comment 13

[Daniel Coloma:dcoloma]

Ups, I think I missed this in the drivers triage. 

Given it was bb+ until this morning, it has r+ from a "gaia-master" I'd suggest we merge it.

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 692968 [details]
Pointer to GH PR #7045

approval granted, as the work is done, has a r+ and is just pending of one reviewer.

Please merge once you get the r+ from Ismael.

Thanks

Comment 15

[Cristian Rodriguez (:crdlc)]

Comment on attachment 692968 [details]
Pointer to GH PR #7045

Better feedback, we were working together and the result is awesome

Comment 16

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/7867115c905cf3ca31942367ea35994d5f5ef41d

thanks to Ismael and Cristian for their excellent contributions to fix this