796424 - [meta] Network error messages should be localized

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect, P1)

Description

[GH to BZ]

[GitHub issue by stasm on 2012-07-24T18:26:40Z, https://github.com/mozilla-b2g/gaia/issues/2752]
Related to #1840. 

When we encounter an network error, the error message text should be shown in the current locale.

In the browser app, we can show error screens that Gecko already has (netError.xhtml).  If we want to use the localizations from Gecko, we'd need (1) to ship a multilocale build of Gecko on the devices and (2) to require a restart when switching the locale.  @jcarpenter What's the UX take on (2)?  Is it fine for v1?

An alternative is to reimplement all error messages in Gaia, but as @jlebar mentions in https://bugzilla.mozilla.org/show_bug.cgi?id=768939, this might be a lot of work.

For other apps, I imagine we'd like to have a different wording for error messages. A comment in #1840 suggests that we'd want a broader approach.  This calls for new error messages.  Will those be displayed by Gaia, or by Gecko?

/cc @fabi1cazenave @vingtetun @autonome @benfrancis

Comment 1

[GH to BZ]

[GitHub comment by benfrancis on 2012-07-25T14:51:52Z]
For the browser app we're currently counting on Gecko's own error pages, so it sounds like that would require a restart for locale changes. The one exception might be "fatal" errors or tab crashes.

I'm not sure which errors should trigger what behaviour in the window manager. From what I understand there's a very long list of different potential errors.

@jcarpenter what additional information do you need to make a call on how the window manager should respond to errors in apps?

Comment 2

[GH to BZ]

[GitHub comment by jcarpenter on 2012-07-30T05:44:13Z]
> In the browser app, we can show error screens that Gecko already has (netError.xhtml). If we want to use the localizations from Gecko, we'd need (1) to ship a multilocale build of Gecko on the devices and (2) to require a restart when switching the locale. @jcarpenter What's the UX take on (2)? Is it fine for v1?

@lco @fabi1cazenave  Do we require a restart for language changes? The [specs](http://people.mozilla.com/~lco/Settings_B2G/Release_1_Specs/R1_Personalization_v1.pdf) (page 19) leave it as an open question. 

I'm fine with requiring a restart. We should consider adding a [Prompt](https://wiki.mozilla.org/Gaia/Design/BuildingBlocks#Prompt). Something along the lines of: 

> "To change the language to [LanguageName] the device must restart" Cancel / Restart

Comment 3

[GH to BZ]

[GitHub comment by jcarpenter on 2012-07-30T05:49:29Z]
@lco Can you work with Ben, Dale and Stas to ensure that we have IxD for the following?

* Network error messages (as per this thread)
* Tab crashes (as per [issue 2283](https://github.com/mozilla-b2g/gaia/issues/2283))

For the later, I think something along the lines of @KaiRo-at 's [suggestion](https://github.com/mozilla-b2g/gaia/issues/2283#issuecomment-7189538) should be sufficient:

> The UI on Fennec XUL is fairly simple, just having "The tab has crashed" (I think that string is a bit more elaborate, should be easy to look up) and two buttons - "Restart Tab" / "Close Tab". We should have the same there for B2G.

Comment 4

[GH to BZ]

[GitHub comment by vingtetun on 2012-07-30T10:44:57Z]
On 30/07/2012 07:44, Josh Carpenter wrote:
>> In the browser app, we can show error screens that Gecko already has (netError.xhtml). If we want to use the localizations from Gecko, we'd need (1) to ship a multilocale build of Gecko on the devices and (2) to require a restart when switching the locale. @jcarpenter What's the UX take on (2)? Is it fine for v1?
> @lco @fabi1cazenave  Do we require a restart for language changes? The [specs](http://people.mozilla.com/~lco/Settings_B2G/Release_1_Specs/R1_Personalization_v1.pdf) (page 19) leave it as an open question.

For v1 a restart is assumed.

>
> I'm fine with requiring a restart. We should consider adding a [Prompt](https://wiki.mozilla.org/Gaia/Design/BuildingBlocks#Prompt). Something along the lines of:
>
>> "To change the language to [LanguageName] the device must restart" Cancel / Restart
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla-b2g/gaia/issues/2752#issuecomment-7360697

Comment 5

[GH to BZ]

[GitHub comment by nhirata on 2012-07-30T16:56:43Z]
Noming for blocking base camp considering our market for initial release.

Comment 6

[GH to BZ]

[GitHub comment by jcarpenter on 2012-08-16T12:25:26Z]
↑ Ping @lco 

https://github.com/mozilla-b2g/gaia/issues/2752#issuecomment-7360751

> Can you work with Ben, Dale and Stas to ensure that we have IxD for the following?
> * Network error messages (as per this thread)
> * Tab crashes (as per issue 2283)

Tab crashes are looking good :) Did we also get Network error messages figured out?

Comment 7

[GH to BZ]

[GitHub comment by fabi1cazenave on 2012-08-23T13:43:23Z]
My understanding for these network error messages is that we need:
* to ship a multi-locale gecko (ugh)
* to ensure that gonk is set with multiple locales (LC_ALL)

Once this is done, all we have to do on Gaia is to force a reboot when the language is changed. Correct?

Comment 8

[GH to BZ]

[GitHub comment by autonome on 2012-09-25T01:21:09Z]
@stasm @fabi1cazenave what's the plan here? what's the concrete work that needs to be done?

Comment 9

[GH to BZ]

[GitHub comment by jcarpenter on 2012-09-25T07:42:50Z]
I believe Gecko errors are already working on the device?

@patrykdesign is working on applying a minor visual treatment here: https://github.com/mozilla-b2g/gaia/issues/5067

Comment 10

[GH to BZ]

[GitHub comment by stasm on 2012-09-25T14:05:16Z]
@autonome The plan is to ship multi-locale Gecko.  I need to talk to releng about the implementation, and we'll likely use a similar approach to the one from multi-locale fennec.  

So the next step is on me: talk to releng.  We'll also need to decide which locales are shipped by default.  With @Pike's work on restartless langpacks, there's a chance we could ship with a small set of locales and offer downloadable langpacks.  My understanding is that we're not limited by space on the device, and shipping with 100 locales in the Gecko part would take up less than 10MB of disk space. 100 being an exaggeration.  20-30 is more likely.

Now that we decided that these error messages will be coming from Gecko and not reimplemented in Gaia, I think we can close this issue.

Comment 11

[Axel Hecht [:Pike]]

I have filed bug 796051 to package the required files only, and bug 796079 to reflect the gaia settings to the right gecko pref, general.useragent.locale.

Comment 12

[Alex Keybl [:akeybl]]

Naoki - Josh thinks this may be fixed (although the blocking bugs haven't been resolved). Can you take a look?

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I'm not sure how you want me to check?  Code wise?  or w/ the device?  

On the device, setting to a different language only shows parts of the ui localized at this moment in time, and I see all the errors in English.

Comment 14

[Axel Hecht [:Pike]]

That's what I'd expect, we'll need the general.useragent fix as well as the packaging of the localized files.

Comment 15

[Axel Hecht [:Pike]]

not taking bugs while on PTO, assigning to default.

Comment 16

[Dietrich Ayala (:dietrich)]

The work is actually happening in the two dependent bugs, both of which are blocking+.

Changing this to meta-bug, removing blocking flag, since it looks confusingly like an actionable unowned blocker.

Comment 17

[BMO Automation]

Firefox OS is not being worked on