796428 - [Quick Settings] Toggling Mobile data while roaming and Data Roaming turned Off

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[GH to BZ]

[GitHub issue by caseyyee on 2012-07-24T21:45:31Z, https://github.com/mozilla-b2g/gaia/issues/2771]
While roaming with Data roaming Off:
Settings -> Network & Connectivity -> Cellular & Data -> Data Roaming [ on | OFF ]

Toggling mobile data on/off in roaming situation from Quick Settings behavior needs to be defined.

Possible resolution:
1. Do not allow Mobile Data to be turned on and present a Alert saying that Mobile Data Roaming is turned Off.

2. Present user with Option to turn on Mobile Data with warning:
"You are current Roaming, turning On Mobile Data will incur additional Data roaming costs"

[Cancel]  [Turn on Mobile Data]

cc: @jcarpenter @timdream @rafaelrebolleda @lco

Comment 1

[GH to BZ]

[GitHub comment by jcarpenter on 2012-07-25T15:21:18Z]
@caseyyee & Marco to look into this.

Comment 2

[GH to BZ]

[GitHub comment by timdream on 2012-07-25T15:56:17Z]
How about we leave the Quick Settings toggle as-is?

The data button toggles `ril.data.enabled` setting -- to enable roaming data, one has to switch on the `ril.data.roaming.enabled` toggle in Settings.

Comment 3

[GH to BZ]

[GitHub comment by caseyyee on 2012-07-26T04:42:06Z]
Because if we do, the user will see that Mobile Data is "On" when in fact it's not and wonder why their data connection is not working.   At the very least, we need some kind of alert box notifying the user that data roaming is turned off and their connection will not function.

The ideal case would be to pop-up the alert and have an option to bring the user directly to the appropriate settings page with the data roaming toggle.

Comment 4

[GH to BZ]

[GitHub comment by marcocimatti on 2012-07-27T08:16:13Z]
I agree with Casey's option: "Present user with Option to turn on Mobile Data with warning: "You are current Roaming, turning On Mobile Data will incur additional Data roaming costs"

...and give user directly the option to turn on anyways or to cancel directly in the alert if at all possible.

Comment 5

[Manuel Casas Barrado [:mancas]]

Attachment: New prompt to alert user

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

Let's first loop UX on this. I believe the string need updates.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

This has sit idle for a week. What happened?

Comment 8

[Stephany Wilkes]

Tim, that's strange. I had a clear list as of yesterday for this Bugzilla ID. I will look into this with the Bugzilla team.

Flagging Jenny on Settings to take the ui-review? flag, which I'll also reassign.

Comment 9

[Jenny Lee]

When user is in roaming area and data connection + data roaming are both set to off, at the moment user tries to turn on data connection from quick setting, show the following dialog:

Title: Turn on data roaming? 
In order to access network via data connection, you also need to turn on data roaming. Depending on your service agreement, extra charges may apply. Do you want to proceed?

[Not now] [Turn ON]

If user taps on "turn on", enable both data connection and data roaming. If user taps on "not now", don't enable both. Thanks!

Comment 10

[Jenny Lee]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

I don't really know what to review in this patch. Tried turning on data connection when roaming is off with a foreign country SIM card but nothing happened. Please let me know what to expect, thanks!

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Manuel,

Could you work with Jenny and provide her some info on what to review?

Comment 12

[Manuel Casas Barrado [:mancas]]

Hi Jenny, I've implemented the new functionality as you described in previous comment. Now you should see the prompt dialog when using a foreign country SIM card. Thanks!

Comment 13

[Jenny Lee]

Attachment: roaming dialog.png

Hey Manuel,

When the dialog is triggered from quick settings and user taps on turn on, the original *first time only* "turn ON data roaming?" dialog triggered from settings will also appear, can you make sure this won't happen? See attached for the dialog I was referring to. Thanks!

Comment 14

[Manuel Casas Barrado [:mancas]]

Hi Jenny, when the "first time only" dialog has never shown, should we keep the state? I mean if the user has never seen the dialog and he set Data On from quick settings, when he come back to settings panel, should he see the "first time only" dialog when toggling Data Roaming switch?

Comment 15

[Jenny Lee]

I've included the important part "Depending on your service agreement, extra charges may apply." that is shown in the "first time only" message in the dialog triggered by quick setting, so I don't think it's necessary to show user again. The state will only be cleared if user has seen the message from quick settings prior to seeing it from settings, which is probably not going happen that often. Hope this makes sense :)

Comment 16

[Manuel Casas Barrado [:mancas]]

(In reply to Jenny Lee from comment #15)
> I've included the important part "Depending on your service agreement, extra
> charges may apply." that is shown in the "first time only" message in the
> dialog triggered by quick setting, so I don't think it's necessary to show
> user again. The state will only be cleared if user has seen the message from
> quick settings prior to seeing it from settings, which is probably not going
> happen that often. Hope this makes sense :)

Hey Jenny, the new behaviour has been implemented. Please take a look when you want. Thanks!

Comment 17

[Jenny Lee]

Thank you Mancas, looks good!

Comment 18

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

I don't know why we are using IAC? What kind of information do we need from the Settings app?

Comment 19

[Manuel Casas Barrado [:mancas]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #18)
> Comment on attachment 8469168 [details] [review]
> New prompt to alert user
> 
> I don't know why we are using IAC? What kind of information do we need from
> the Settings app?

We need to use IAC because we must change a flag in the async storage on settings scope, in order to don't show again the first time only dialog if it has been already shown by clicking in the quick settings.

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Manuel Casas Barrado [:mancas] from comment #19)
> We need to use IAC because we must change a flag in the async storage on
> settings scope, in order to don't show again the first time only dialog if
> it has been already shown by clicking in the quick settings.

Can we move that flag to mozSettings?

Comment 21

[Manuel Casas Barrado [:mancas]]

Please take a look at the new commit. Thanks!

Comment 22

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

This need review from Settings app owner.

Apologies -- I actually didn't realize the flags are stored in asyncStorage before this patch, that's why I suggest we should move it.

Comment 23

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

.. and the System part should be reviewed by someone working on utility tray/quick settings in systemsfe team. Kevin, could you redirect?

Comment 24

[Kevin Grandon :kgrandon]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

Guillaume was doing most of the utility tray work I believe, so redirecting to him. Guillaume - if you're too busy for this let me know and I can take a look this week. Thanks!

Comment 25

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

Looks good to me for the settings part, thanks.

Comment 26

[Guillaume Marty [:gmarty]]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

Sorry Kevin, I meant to do it today but didn't find the time. I'm attending a conference tomorrow. I redirect the r? to you.

Comment 27

[Kevin Grandon :kgrandon]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

Hey Manuel,

Could you clarify something for me? I was testing this, and it seemed that it prompts me when I have data connection enabled, but roaming turned off.. Why does it need to do this? Shouldn't it just turn it on? I also wonder if it could be because of some recent merge conflicts due to changes under you. Sorry we didn't get to this sooner.

Comment 28

[Manuel Casas Barrado [:mancas]]

Hi Kevin!
Sorry for that, it was my fault! Now it should be working as expected

Thanks!

Comment 29

[Kevin Grandon :kgrandon]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

I will take a look shortly.

Comment 30

[Kevin Grandon :kgrandon]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

Hey, I have a question about a function naming and an unused setting on github. Can you address these and re-request review from me? Thanks!

Comment 31

[Manuel Casas Barrado [:mancas]]

Hey Kevin, I've answered your questions in github. Please take a look. Thanks!

Comment 32

[Kevin Grandon :kgrandon]

Comment on attachment 8469168 [details] [review]
New prompt to alert user

Seems fine to me then. Thanks!

Comment 33

[Carsten Book [:Tomcat]]

master: https://github.com/mozilla-b2g/gaia/commit/9a73b83ede782e1ff5dc43c4c6a8166360f80569