796479 - [settings][wifi] "search again" button looks like a bit... IE5

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[GH to BZ]

[GitHub issue by autonome on 2012-08-14T04:43:48Z, https://github.com/mozilla-b2g/gaia/issues/3418]
Otoro.

Comment 1

[GH to BZ]

[GitHub comment by timdream on 2012-08-14T05:16:55Z]
@fabi1cazenave @evelynhung @patrykdesign ^

Comment 2

[GH to BZ]

[GitHub comment by patrykdesign on 2012-08-21T19:33:56Z]
@autonome do can you attach a screenshot?

Comment 3

[GH to BZ]

[GitHub comment by PeterLa on 2012-09-10T17:26:55Z]
I took a screenshot: https://www.dropbox.com/s/bmot5du3tjdw4fc/WifiSearchAgainButton.png

It doesn't seem to use the system button as defined in the common controls building blocks.  This is a dev isssue then?

Comment 4

[GH to BZ]

[GitHub comment by fabi1cazenave on 2012-09-10T17:47:28Z]
1. yes, there is a bug (regression), though not the one @autonome first mentioned;
2. button building blocks haven’t landed yet — at least, not in the Gaia shared/style/ directory.

Concerning these building blocks, the first step would be to apply the ones that are currently in Gaia shared/style/ (= headers and switches) in all Gaia applications — many of them are using a local copy of the building blocks, which completely removes the point of this work. We could open bugs for each app and see if they can get a `blocking-basecamp+` flag.

Currently, only Dialog boxes are pending review — the rest of the Building Blocks hasn’t been submitted to Gaia yet. Feel free to prioritize other visual assets: it takes some time to adapt the markup used by the current Building Blocks to match the rules we have for Gaia (= generic markup + aria roles + as few arbitrary classes as possible).

Comment 5

[Fabien Cazenave [:kaze]]

This should be fixed. Dietrich, is this OK now?

Comment 6

[Fabien Cazenave [:kaze]]

Considering as fixed since we’re using the shared `buttons.css` stylesheet.

Comment 7

[Rebecca Billings [:rbillings]]

Verified on the 11/19 unagi build that Search Again button UI matches the rest of the phone.