796484 - [keyboard] switching to a double byte keyboard will cause the phone to reboot.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P3)

Description

[GH to BZ]

[GitHub issue by nhirata on 2012-08-15T00:04:11Z, https://github.com/mozilla-b2g/gaia/issues/3458]
## Environment :
Otoro phone, build 2012-08-14
Taken from default.xml in b2g-distro: 
* "platform_build" revision= 9d84ba558d495cb515d38bd1b4327b7bd3577854
* "gaia" revision= ce3287d058fe55ff34a9fd0fe3daa0029d4d3d08 
* "mozilla-central" revision= 9f4e1d00dfa611a3f0ec30a9fcbf6564cd9d39cf
* "gonk-misc" revision= 5c4dbf85081cf4d5556cac479652be0efb96a62d

## Repro :
1. go to settings -> keyboard
2. check mark all layouts for every language
3. go back to home screen
4. launch browser app
5. click in url
6. quickly cycle through all the keyboard types

## Expected :
1. no crash, no reboot of phone

## Actual :
1. if you cycle fast enough through them, eventually you will crash and reboot the phone. 
2. typing in Japanese seems to accelerate it.... that might be a separate crash due to the undefined dictionary?

## Note :
* logcat: https://gist.github.com/3354024
* I don't think that this bug in itself is an issue, I'm worried if there might be something else that's underlying.

Comment 1

[GH to BZ]

[GitHub comment by autonome on 2012-09-05T06:03:48Z]
@RudyLu can you please look into this? Thanks!

Comment 2

[GH to BZ]

[GitHub comment by RudyLu on 2012-09-05T07:06:51Z]
From my test, 

1. Simply enabling the Japanese keyboard could reproduce the reboot.
     - See the STR1 for details.
2. If we enable all the keyboard layouts for V1 (English, Portuguese, Spanish, etc.), this issue would not occur.

Suggest to re-nominate non-blocker if point 2 is confirmed.

STR1
===
1. Enable Japanese keyboard and disable all other keyboard layouts.
2. Go to an input field and activate the keyboard.
3. After a while, the phone will reboot.

ping @yxl and @kylewu, the author of Japanese IME for help.
Did you encounter this situation before?
Thanks.

Comment 3

[GH to BZ]

[GitHub comment by lodr on 2012-09-05T18:10:37Z]
I remember to have detected this issue in Barcelona working week. I think it is because the size of the database but I'm not sure about it.

Comment 4

[GH to BZ]

[GitHub comment by RudyLu on 2012-09-12T06:42:50Z]
@nhirata, could you help confirm that this issue would not occur if we do not enable the IMEs which are not in the V1 scope, including Japanese IME?
If that is the case, I think we could re-nominate this issue.

Comment 5

[GH to BZ]

[GitHub comment by nhirata on 2012-09-12T17:17:45Z]
Just a FYI, there are Japanese people in Brazil : http://en.wikipedia.org/wiki/Japanese_Brazilian  I will spend some time to investigate this today.

Comment 6

[GH to BZ]

[GitHub comment by nhirata on 2012-09-12T18:29:52Z]
Looks like Chinese will also cause this issue to occur.  It takes a lot longer.

Hebrew seems to be ok.  Greek seems to be ok.  Arabic seems ok. In fact all the other keyboard types seem ok.

I think it has to do with double byte characters in general.  I retitled the bug to make more sense given what we tested.

Tested with Otoro phone, build 2012-09-12
Taken from default.xml in b2g-distro: 
* "platform_build" revision= 1532e3d7099724a8701da220ce29e705a33f78eb
* "gaia" revision= 0ec99508cc5198ff0908a85ab624f8bf08f28e31 
* "mozilla-central" revision= 0ce1f32125257961232c65c7d6251314f9e0f2be
* "gonk-misc" revision= ec56d3ede37a051321ea7c1973b5c29ef53a88db

Comment 7

[GH to BZ]

[GitHub comment by kylewu on 2012-09-13T00:03:16Z]
@RudyLu @nhirata Simple Chinese, traditional Chinese and Japanese IMEs use a huge dictionary-like database (at least by now). Other western IMEs do not need this. They only use key mapping to input I believe.
Querying database uses a lot of memory and there is no restrict to use memory. **Maybe** this is the problem. But when we implemented IME in desktop, we didn't find this problem.

@nhirata Could you check if traditional Chinese IME also cause crash? Thanks.

BTW It's definitely necessary to optimize these three IMEs I mentioned above. There is huge space to improve compared to current IMEs in Desktop.

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

According to Comment 7, this should be an OOM issue and for now we may not have enough time to come out with another implementation for this.


Dear Chris,

Is it possible we could just remove those Asian IMEs for now since they are not for V1?
Thanks.

Comment 9

[Andreas Gal :gal]

We can disable asian IMEs for now.

Comment 10

[Mike Connor [:mconnor]]

P3: Please proceed with Andreas' solution to remove the Asian IMEs for v1.

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6149

Pointer to Github pull-request

Comment 12

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 677729 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/6149

The Asian IMEs may cause OOM, so we decide to remove them from the general keyboard layout settings.
However, we would keep it in the developer section for future development/improvement.

Hi Kaze,

Could you please review this settings related change?
Thank you.

Comment 13

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/9978a690ed8495229fbb899a454e642de3066f91

Comment 14

[Chris Peterson [:cpeterson]]

Rudy, the user can still switch to Chinese or Arabic locale from the phone's Settings > Language menu. Is that expected?

Comment 15

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Chris,

Yes, this issue is about Asian IMEs in keyboard, not about the language settings of the phone.

Thanks.

Comment 16

[Allen Maxwell]

Issue no longer occurs on Unagi, Build ID:20121231070201
Unconfirmed on Otoro (no device available)

Comment 17

[pallavi]

Issue is fixed on Unagi, Build Id:20130112070202

Note: Asian languages are removed