796515 - [BB][SMS] Apply [input_areas] fixes => Text field to type SMS message is too narrow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[GH to BZ]

[GitHub issue by mounirlamouri on 2012-08-22T22:34:46Z, https://github.com/mozilla-b2g/gaia/issues/3725]
The caret is as tall as the text field. There should be a bit of padding to make the text field feels more large and improve experience.

Comment 1

[GH to BZ]

[GitHub comment by nhirata on 2012-08-22T22:58:08Z]
Noming for soft block?

Comment 2

[GH to BZ]

[GitHub comment by fcampo on 2012-08-24T15:06:21Z]
I'm adding UX label to this, as is a decision for them

Comment 3

[GH to BZ]

[GitHub comment by fcampo on 2012-08-24T15:18:33Z]
Related to #3505 ??

Comment 4

[GH to BZ]

[GitHub comment by mounirlamouri on 2012-08-24T16:10:24Z]
That's on an Otoro so I don't know.

Comment 5

[GH to BZ]

[GitHub comment by fcampo on 2012-08-24T16:20:15Z]
I think that 3505 issue is on a Nexus S
In which one are you testing?

Comment 6

[GH to BZ]

[GitHub comment by mounirlamouri on 2012-08-24T16:24:10Z]
Sorry, by "that's", I meant "This bug".

Comment 7

[GH to BZ]

[GitHub comment by fcampo on 2012-08-24T16:32:43Z]
Oh :) Sorry then

Anyway, let's wait to see if someone from UX have a saying on this
@jcarpenter 
@silvialatzer, any comments?

Comment 8

[GH to BZ]

[GitHub comment by jcarpenter on 2012-08-27T06:47:40Z]
> The caret is as tall as the text field. There should be a bit of padding to make the text field feels more large and improve experience.

I think the issue here is height, not width, correct? If so, I have to agree. Our text fields have always felt a bit tight...

@authoritaire @patrykdesign Thoughts?

Comment 9

[GH to BZ]

[GitHub comment by jcarpenter on 2012-08-27T06:49:06Z]
> Noming for soft block?

Not in my opinion. This is a visual design tweak.

Comment 10

[GH to BZ]

[GitHub comment by SerRodSan on 2012-08-28T10:57:26Z]
As I commented before, unfortunately @authoritaire is not available right now, so I´ll comments this. 
If I understood correctly, with too narrow you meant not high enough, so you would like the input field to be a bit higher, right?
In that case, IMHO inputs are currently harmonized with and the same height as buttons and other form elements. For the moment, we shall keep this height unless we should decide to redesign all form element sizes after Sao Paulo worksessions. The intermittent resolve shall be to be make the caret smaller, not the input field bigger

Comment 11

[GH to BZ]

[GitHub comment by mounirlamouri on 2012-08-28T18:59:29Z]
I don't understand how you can have a so small input. The main thing to do when you type a SMS is typing the SMS. The fact that the typing area is so small is ridiculous! Even the "address" text field is bigger.

Comment 12

[GH to BZ]

[GitHub comment by autonome on 2012-09-12T16:22:25Z]
Not blocking, but yeah that's pretty darn small. @albertopq who can fix this visual tweak?

Comment 13

[GH to BZ]

[GitHub comment by fcampo on 2012-09-12T16:40:23Z]
I can try and implement it, as soon as someone from UX gives us the proper sizes.
Usually @silvialatzer does that, but I don't know what you guys decided in brazil

Comment 14

[GH to BZ]

[GitHub comment by jcarpenter on 2012-09-13T03:32:56Z]
> @albertopq who can fix this visual tweak?

> ...inputs are currently harmonized with and the same height as buttons and other form elements. For the moment, we shall keep this height unless we should decide to redesign all form element sizes after Sao Paulo worksessions. 

That is exactly right. The visual design team puts extraordinary care towards system-wide consistency of elements such as these. If we make changes, we have to make them system wide.

The visual design decision makers here are Patryk and Steve ( @authoritaire @patrykdesign ). This will have to wait until they return from PTO. Patryk is back on Monday 9/17, AFAIK.

Comment 15

[Patryk Adamczyk [:patryk] UX]

Yes we talked about increasing the sizing... is there a building block for this? Or does each developer need a spec?

Comment 16

[Ismael Gonzalez [:basiclines]]

This should be fixed by using building blocks. I'm working on it right now!

Comment 17

[Ismael Gonzalez [:basiclines]]

I've just made a PR: https://github.com/mozilla-b2g/gaia/pull/5690 fixing it, and adding more improves.

Comment 18

[Ismael Gonzalez [:basiclines]]

Attachment: Added input_areas, edit_mode and switches

Comment 19

[Ismael Gonzalez [:basiclines]]

I've removed the old PR as rebase problems, check the new one:
https://github.com/mozilla-b2g/gaia/pull/5691

Comment 20

[Ismael Gonzalez [:basiclines]]

Attachment: This patchs removes extra commits from previous one

Comment 21

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

Comment 22

[David Scravaglieri [:scravag]]

Comment on attachment 668471 [details]
This patchs removes extra commits from previous one

NOTE: If blocking-basecamp+ is set, just land it for now.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed: 
Risk to taking this patch (and alternatives if risky):

Comment 23

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 668471 [details]
This patchs removes extra commits from previous one

a=me if you removed the dead code and the 3 console.logs that have been introduced in this path (in sms.js).

Comment 24

[Ismael Gonzalez [:basiclines]]

The console log was already removed, i need to update the patch in bugzilla, but in GH is ok

Comment 25

[Borja Salguero [:borjasalguero]]

r+! Great job Ismael! Merged.

Comment 26

[Allen Maxwell]

Verified as resolved on Unagi Build ID:20121231070201
Unable to verify on Otoro, only have Unagi

Comment 27

[Natalya Kot [:nkot]]

fix verified in Build 20130113070202 for Unagi - Text field to type SMS message looks nice