Closed
Bug 796623
Opened 12 years ago
Closed 11 years ago
[Settings] JS Error on B2G Desktop
Categories
(Firefox OS Graveyard :: Gaia::Settings, defect)
Firefox OS Graveyard
Gaia::Settings
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: ghtobz, Assigned: janjongboom)
Details
(Whiteboard: [label:settings])
Attachments
(1 file)
[GitHub issue by timdream on 2012-09-11T10:31:38Z, https://github.com/mozilla-b2g/gaia/issues/4558] Error: TypeError: gMobileConnection.iccInfo is undefined Source File: http://settings.gaiamobile.org:8080/js/data.js Line: 45 Looks like fake orange doesn't include some fields?
Updated•12 years ago
|
Component: Gaia → Gaia::Settings
Assignee | ||
Comment 1•11 years ago
|
||
Fix for B2G desktop. There should have been a return statement here all along.
Attachment #773859 -
Flags: review?(ehung)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → janjongboom
Comment 2•11 years ago
|
||
Comment on attachment 773859 [details] [review] Patch redirect to Arthur for a test. Thanks.
Attachment #773859 -
Flags: review?(ehung) → review?(arthur.chen)
Comment 3•11 years ago
|
||
Comment on attachment 773859 [details] [review] Patch r=me. Thanks for the fix!
Attachment #773859 -
Flags: review?(arthur.chen) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Landed in https://github.com/mozilla-b2g/gaia/commit/06ea1e6a981a6bfd5390b262c6550b06dd6e8c6c
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•