Closed Bug 796623 Opened 9 years ago Closed 8 years ago

[Settings] JS Error on B2G Desktop

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ghtobz, Assigned: janjongboom)

Details

(Whiteboard: [label:settings])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
arthurcc
: review+
Details | Review
[GitHub issue by timdream on 2012-09-11T10:31:38Z, https://github.com/mozilla-b2g/gaia/issues/4558]
    Error: TypeError: gMobileConnection.iccInfo is undefined
    Source File: http://settings.gaiamobile.org:8080/js/data.js
    Line: 45

Looks like fake orange doesn't include some fields?
Component: Gaia → Gaia::Settings
Attached file Patch
Fix for B2G desktop. There should have been a return statement here all along.
Attachment #773859 - Flags: review?(ehung)
Assignee: nobody → janjongboom
Comment on attachment 773859 [details] [review]
Patch

redirect to Arthur for a test. Thanks.
Attachment #773859 - Flags: review?(ehung) → review?(arthur.chen)
Comment on attachment 773859 [details] [review]
Patch

r=me. Thanks for the fix!
Attachment #773859 - Flags: review?(arthur.chen) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.