796628 - [Music App] Music continues to play during a connected call

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P1)

Description

[GH to BZ]

[GitHub issue by tonychung on 2012-09-12T05:48:45Z, https://github.com/mozilla-b2g/gaia/issues/4609]
Music continues to play through the phone at a reduced volume when dialing or receiving a call.    

## Environment :
* Otoro daily: 9-11-2012
* gaia commit: 6cb41daf1073643c86d74624dd8cf55950171e3d
* gecko commit: 105845cdabbd043b9975a6937ebd84e3ff4cdca3


## Repro :
1. Launch the Music App and play a song either through the device speaker or your headphones
2. switch to dialer app, and make an outgoing call to another phone
3. Verify once the call is connected, the music has softened, but its still playing while the call is connected.
4. Repeat steps 1-3, except this time, answer your phone with music playback from another phone.


## Expected :
* Music playback should pause (maybe even fade out slowly, and fade back in -- @jcarpenter?) , when a call is connected.

## Actual :
* Music playback continues to play on the phone at a reduced volume.  it's soft, but its annoying enough that it interrupts the call.

Comment 1

[GH to BZ]

[GitHub comment by jcarpenter on 2012-09-12T06:05:13Z]
Agreed. Audio volume should reduce to zero, via a .5-2 second fade out, and then back in to it's previous volume once the call has concluded.

cc'ing @aymanmaat @caseyyee for confirmation. They are responsible for Dialer and Sound UX, respectively. The full picture may be more complex.

Comment 2

[GH to BZ]

[GitHub comment by nhirata on 2012-09-12T17:12:15Z]
related to #3720; it's not just the music app... we have to worry about video and browser as well.

Comment 3

[GH to BZ]

[GitHub comment by timdream on 2012-09-13T05:41:28Z]
I try to reproduce this issue ..... but the Music app crashes when the phone call is connected!!

Comment 4

[GH to BZ]

[GitHub comment by timdream on 2012-09-13T05:41:48Z]
That kind of solves the issue right?

Comment 5

[GH to BZ]

[GitHub comment by tonychung on 2012-09-13T06:08:55Z]
hah!  no.

Comment 6

[GH to BZ]

[GitHub comment by timdream on 2012-09-13T06:09:48Z]
@tonychung I was kidding lah.

Comment 7

[GH to BZ]

[GitHub comment by caseyyee on 2012-09-19T01:31:33Z]
Just to expand on Josh's recommendation

Incoming call while music is playing:
- Incoming call screen should be displayed.
- Music should fade out and paused
- Phone ring should playback in headset.

At this point, the user either accepts the incoming call or declines the call.  Once the call activity is ended:
- Music is is played.
- Volume fades back up to previous levels.

There are other cases as well such as Outgoing calls, Incoming SMS alerts, notifications, etc.  These are being detailed in a audio prioritization matrix that I'm working on.   I will update this issue when i have updates to post.

Comment 8

[GH to BZ]

[GitHub comment by jcarpenter on 2012-09-19T01:51:12Z]
> * Incoming call screen should be displayed.
* Music should fade out and paused
* Phone ring should playback in headset.

@timdream, just to clarify: those three steps should happen simultaneously.

> There are other cases as well such as Outgoing calls, Incoming SMS alerts, notifications, etc. These are being detailed in a audio prioritization matrix that I'm working on. I will update this issue when i have updates to post.

@caseyyee [Larissa's comment](https://github.com/mozilla-b2g/gaia/issues/2562#issuecomment-8518083) in #2562 is relevant also.

Comment 9

[GH to BZ]

[GitHub comment by timdream on 2012-09-19T03:15:03Z]
@jcarpenter we don't have a mean to do audio prioritization :-/ That requires platform support ...

Comment 10

[GH to BZ]

[GitHub comment by autonome on 2012-09-21T16:17:26Z]
@timdream can you file the platform bug? Discussed in triage and sounds like platform solution is the only way to solve problems like cancelling music during emergency calls.

Comment 11

[GH to BZ]

[GitHub comment by alivedise on 2012-09-28T04:00:27Z]
Also relevant: #5363

Comment 12

[GH to BZ]

[GitHub comment by jcarpenter on 2012-09-28T05:41:08Z]
@caseyyee To put this on your radar

Comment 13

[Andrew Overholt [:overholt]]

Does this depend upon bug #795237?

Comment 14

[Andrew Overholt [:overholt]]

Vivien, who can take a look at this?

Comment 16

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Music app app would need to specify audio stream type properly. That is bug 796628.

Comment 17

[Chris Lee [:clee]]

Increasing the priority based on partner request.

Comment 19

[Daniel Coloma:dcoloma]

New feature work so tagged as feature and P1

Comment 20

[Andreas Gal :gal]

Need an owner here. I doubt Vivien has cycles for this.

Comment 21

[(inactive after 6/18) Alive Kuo [:alive]]

I believe Marco/Randy is owning...not sure who is owning gecko side.
We have a proposal about audio competing policy here: https://docs.google.com/file/d/0BxKpB0y8NZSHYjhJeUtQUkRQVUU/edit?pli=1

Comment 22

[James Ho]

tentatively assigned to Marco as this is blocked by bug #805333.

Comment 23

[Alex Keybl [:akeybl]]

We're marking this bug with the C1 milestone since it follows the criteria of "unfinished feature work" (see https://etherpad.mozilla.org/b2g-convergence-schedule).

If this work is not finished by Nov19, this bug will need an exception and will be called out at the upcoming Exec Review.

Comment 24

[Alex Keybl [:akeybl]]

This bug has been called out as likely having risk to non-B2G platforms. Given that, marking as P1, and moving into the C2 milestone. We should prioritize this landing to mozilla-beta as soon as possible, to prevent late-breaking regressions to other platforms.

Comment 25

[Walter Chen[:ypwalter][:wachen]]

Just find the same issue on unagi daily build 11/22/2012.
Please also note that not only the music is playing, there are still some other side effects.

Whatever you said to phone wont be transmit to the received/dialed caller when there is a music app on the background.

Comment 26

[Dietrich Ayala (:dietrich)]

Dominic, once bug 805333 is fixed, what is the expected time to fix this?

Comment 27

[Dominic Kuo [:dkuo]]

Hey Dietrich, after bug 805333 is fixed, Music app should receive some events like mozinterruptbegin/mozinterruptend, what Music needs to do is handling these events,
and maybe pause at mozinterruptbegin, resume at mozinterruptend.
This won't be too hard and takes little time to fix.

Comment 28

[Joe Cheng [:jcheng] (please needinfo)]

Hi Dominic, now that 805333 landed, can you keep everyone updated as to where you are with the bug? thanks

Comment 29

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

We also need bug 815445 for this to work.

Comment 30

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

(In reply to Dominic Kuo [:dkuo] from comment #27)
> Hey Dietrich, after bug 805333 is fixed, Music app should receive some
> events like mozinterruptbegin/mozinterruptend, what Music needs to do is
> handling these events,
> and maybe pause at mozinterruptbegin, resume at mozinterruptend.
> This won't be too hard and takes little time to fix.

I'm not sure if there's any followup work needed here after bug 815445 to resume music after a call, but if so let's file that as a followup bug.

NB: marking RESO FIXED when these bugs hit beta because it's getting hard for b2g folks to track remaining work for upcoming milestones.

Comment 31

[Dominic Kuo [:dkuo]]

There is one follow up work for Music app, please see bug 819873, thanks.

Comment 32

[Diego Wilson [:diego]]

I can still reproduce this issue. I assume it'll get fixed when bug 819873 is addressed

Comment 33

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Bug 819873 wasn't supposed to have been needed for this ...

Comment 34

[Diego Wilson [:diego]]

Oh my bad. I (wrongly) assumed the incoming call use case also be solved by this. The outgoing call use was is fixed.

Comment 35

[Diego Wilson [:diego]]

Any chance that when bug 819873 is solved the incoming call use case is solved?

Comment 36

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Both incoming and outgoing calls should have been fixed automatically once bug 805333 and bug 815445 was fixed.

Are you sure this doesn't work?

Marco: Can you debug what's wrong here?

Comment 37

[Diego Wilson [:diego]]

Works for incoming call too! Must've not picked up the fix right before. Thanks!

Comment 38

[Marcia Knous [:marcia]]

I can verify this is fixed using the latest nightly build (20121212). I tested both incoming and outgoing calls with music playing and I no longer hear the music.