796680 - [Message] There is no hit state on all buttons on header

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia, defect)

Description

[GH to BZ]

[GitHub issue by timdream on 2012-09-19T04:19:58Z, https://github.com/mozilla-b2g/gaia/issues/4896]
According to BB or Contact app (?), buttons should turn to blue when being pressed.

On a touch screen without hit state it will be very to tell if one have actually pressed the button or not.

Comment 1

[GH to BZ]

[GitHub comment by patrykdesign on 2012-09-25T14:39:55Z]
@timdream is the functionality in place? We do have a graphics for this function. What needs to be done to solve this? A spec?

Comment 2

[GH to BZ]

[GitHub comment by timdream on 2012-09-25T17:31:25Z]
I don't think we don't have VsD on that. It's just something devs forget to put in. @steveck-chung Please reassign to responsible people.

Comment 3

[GH to BZ]

[GitHub comment by autonome on 2012-09-26T16:32:45Z]
Why should this block the release? Lots of our buttons don't have hit state, but we are able to use them ok.

Comment 4

[GH to BZ]

[GitHub comment by autonome on 2012-09-26T16:34:55Z]
I just tested email, calendar and they don't have hit state change either. Contacts has it. Not going to block, this is a nice polish fix.

Comment 5

[GH to BZ]

[GitHub comment by steveck-chung on 2012-10-01T08:49:03Z]
Hi @borjasalguero , I've saw the sms building-block integration in PR in https://github.com/mozilla-b2g/gaia/pull/4977. Will @basiclines help us to apply the building-block in whole sms app or the need to finish the remaining part by ourself?
BTW, thanks for the great efforts in sms, @basiclines  :)

Comment 6

[GH to BZ]

[GitHub comment by basiclines on 2012-10-01T08:51:07Z]
Hey! @autonome  @steveck-chung the hit states are in this PR: https://github.com/mozilla-b2g/gaia/pull/4977 as soon as is being landed sms will have the BB headers with all these benefits.
BTW i will still working in implementing BB in the applications! But just step by step!