796686 - [Settings] Need 2G/3G preferred network type selection UI

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect, P1)

Description

[GH to BZ]

[GitHub issue by vicamo on 2012-09-20T04:13:31Z, https://github.com/mozilla-b2g/gaia/issues/4944]
[Bugzilla 787420](https://bugzilla.mozilla.org/show_bug.cgi?id=787420) implements preferred network type selection by introducing new Settings API key "ril.radio.preferredNetworkType", possible values "gsm", "wcdma" and "wcdma/gsm". A debug is also available in the same page for function tests.

Comment 1

[GH to BZ]

[GitHub comment by autonome on 2012-09-26T06:39:14Z]
We don't support CDMA for v1. Why does this block the release?

Comment 2

[GH to BZ]

[GitHub comment by vicamo on 2012-09-26T17:08:13Z]
W-CDMA is not CDMA. Well, that's a long story, but it's the 3G network you used and GSM is the 2G one currently on B2G.

Comment 3

[GH to BZ]

[GitHub comment by caseyyee on 2012-09-26T19:26:30Z]
In what cases would a user need to switch network types?   I would think that this should be automatic and always default to the fastest available network type.

If we need a control like this, it would make sense to put it into Settings -> Cellular & Data.

@lco?

Comment 4

[GH to BZ]

[GitHub comment by lco on 2012-09-26T23:13:55Z]
We could put it in the advanced section of Cellular/Data. See pg. 27: http://people.mozilla.com/~lco/Settings_B2G/Release_1_Specs/R1_Connectivity_v10.pdf

But please let me know if this is definitely a requirement for v1.

Comment 5

[GH to BZ]

[GitHub comment by evelynhung on 2012-09-27T11:33:47Z]
Is #3649 the same issue?

Comment 6

[GH to BZ]

[GitHub comment by caseyyee on 2012-09-27T18:38:03Z]
@evelynhung this is a different issue.   The use case here is that switching to 2G could save battery life.

@clee can you confirm that this is required for V1?

Comment 7

[GH to BZ]

[GitHub comment by clee on 2012-09-27T19:46:03Z]
@caseyyee Wrong clee. @cleemoz is the one you want :)

Comment 8

[GH to BZ]

[GitHub comment by cleemoz on 2012-09-29T01:30:02Z]
I'd kick this to @dcoloma -- can you confirm if we need a 2G/3G toggle?

Comment 9

[Daniel Coloma:dcoloma]

As a user, I would definitely love that feature, but I want to check if this a must have for device certification. 

Will come back to you soon.

Comment 10

[Daniel Coloma:dcoloma]

We have just confirmed that it is a certification requirement.

Comment 11

[Beatriz Rodríguez [:brg]]

I just want to emphasize that this setting must have three options and user must choose 1:
- Automatic mode: 2G/3G (default value)
- Only 2G
- Only 3G

Comment 12

[Larissa Co [:lco]]

Taking this, and will update the spec soon.

Comment 13

[Larissa Co [:lco]]

Spec uploaded (v11): http://people.mozilla.com/~lco/Settings_B2G/Release_1_Specs/R1_Connectivity_v11.pdf

See pg. 29.

Comment 14

[Larissa Co [:lco]]

Dietrich, can you please assign to the engineer who'll work on this? The spec is finished.

Comment 15

[Philipp von Weitershausen [:philikon]]

Tentatively assigning Kaze... Kaze, do you think you can take this? Thanks!

Comment 16

[Fabien Cazenave [:kaze]]

@philikon the front-end side is trivial, but I’m not sure about the back-end side. If you feel confident about this I can do what it takes to make it work — including working a couple weeks in California.

Comment 17

[Philipp von Weitershausen [:philikon]]

(In reply to Fabien Cazenave [:kaze] from comment #16)
> @philikon the front-end side is trivial, but I’m not sure about the back-end
> side.

What besides bug 787420 is needed? I was under the impression we just need to implement a UI for the setting at this point.

Comment 18

[Fabien Cazenave [:kaze]]

If the back-end’s ready, that should be easy. Lemme see.

Comment 19

[Philipp von Weitershausen [:philikon]]

Awesome. Thanks! Basically, the 'ril.radio.preferredNetworkType' setting can be one of these values:

  const GECKO_PREFERRED_NETWORK_TYPE_WCDMA_GSM = "wcdma/gsm";
  const GECKO_PREFERRED_NETWORK_TYPE_GSM_ONLY = "gsm";
  const GECKO_PREFERRED_NETWORK_TYPE_WCDMA_ONLY = "wcdma";

Comment 20

[c_vkeaga]

On latest build i tried changing the network from GSM to WCDMA using setting 'ril.radio.preferredNetworkType'   and it works fine, but the data type is not changing from E to H.

Comment 22

[Alex Keybl [:akeybl]]

We're marking this bug with the C1 milestone since it follows the criteria of "unfinished feature work" (see https://etherpad.mozilla.org/b2g-convergence-schedule).

If this work is not finished by Nov19, this bug will need an exception and will be called out at the upcoming Exec Review.

Comment 23

[Andreas Gal :gal]

kaze, whats the status here?

Comment 24

[Fabien Cazenave [:kaze]]

I’m finishing another bug atm, this one is next on my list. Should be done today.

Comment 25

[Fabien Cazenave [:kaze]]

Attachment: layout fixes

Comment 26

[Misty Byrd]

This issue fixed for  device Ungia; build #20121231070201 v.1