796702 - [Calendar] When I switch to a different day in the day view, the day selected and shown in the month view should update respectively

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[GH to BZ]

[GitHub issue by jds2501 on 2012-09-21T18:23:48Z, https://github.com/mozilla-b2g/gaia/issues/5036]
## Build

* Device: Otoro
* Gaia: e721ac345b957e658bb78f1618438668732c6d94
* Mozilla Central: 4e49e8497cc2ac4dd40fe29a63c05991eeefc2d0

## Steps

1. Open the day view in the calendar
2. Switch to a new day
3. Go back to the month view

## Expected

The day shown in the month view should be changed to reflect the change made in the day view.

## Actual

The day in the month view doesn't change. Probably not a blocker, but definitely polish to improve the UX.

cc @lightsofapollo

Comment 1

[GH to BZ]

[GitHub comment by lightsofapollo on 2012-09-21T18:25:57Z]
@michalbe There is logic to do inverse in day view (for selectedDay switching in month view) it should be very easy to apply the same logic to the day view -> month view case.

Comment 2

[James Lal [:lightsofapollo]]

Also seen in week view, sometimes works but under some conditions fails.

Comment 3

[Igor]

Attachment: Pointer to GitHub patch

Simple patch for this bug. 
GH pull request: https://github.com/mozilla-b2g/gaia/pull/13049

Comment 4

[James Lal [:lightsofapollo]]

Comment on attachment 821398 [details]
Pointer to GitHub patch

Fell _way_ off my radar sorry for the long turn-around... I am going to assign review to kgrandon though

Comment 5

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Appears that the attached PR links to the wrong commit, so fixing that here.

I'll mark myself to review this later, but we're going to be unable to land as-is without tests.

Comment 6

[Kevin Grandon :kgrandon]

Hi Igor,

I think we will need a unit test to land this. Would you like to add a unit test to this? If you don't have the time to do so, I can take over the patch - just let me know.

Information on unit tests: https://github.com/mozilla-b2g/gaia/#unit-tests

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 828446 [details] [review]
Github pull request

Clearing review flag for now.

Comment 8

[Igor]

Kevin,

I would like to add the unit test, but I have never coded one. I'll try to do it in this weekend.

Comment 9

[Igor]

I added a unit test in test_day.js . 

Is it enough or perhaps a marionette test would be more suitable?

Thanks.

Comment 10

[Kevin Grandon :kgrandon]

Nice work, this will do for now, and we can always follow-up with a marionette test. If you have some cycles to build one, it would be much appreciated.

Thanks for your contribution!

Comment 11

[Kevin Grandon :kgrandon]

https://github.com/mozilla-b2g/gaia/commit/a32e81bf56a0326dfcadcacf176f48a682a0dce4