[GitHub issue by lightsofapollo on 2012-09-27T10:49:54Z, https://github.com/mozilla-b2g/gaia/issues/5296] With a start value date|time should start the picker at the correct value.
[GitHub comment by lightsofapollo on 2012-09-27T11:00:38Z] https://bugzilla.mozilla.org/show_bug.cgi?id=794878 <- bugzilla side of the issue.
[GitHub comment by autonome on 2012-09-28T07:04:25Z] is there any gaia-side work when platform fix lands?
[GitHub comment by lightsofapollo on 2012-09-28T07:05:50Z] yes, we will need to parse the value passed from gecko into something we can use to update the date & time pickers. I have code for this landed in calendar for my own uses we can use the same or similar logic in the system app.
The platform fix has landed. James, can you link the calendar code, so someone else can implement for the system app?
Yes, https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/js/input_parser.js Its ready to be directly dropped into the system app if the "Calendar." part is removed. The InputParser deals with both import (string -> object) and export (date -> string) so not everything is relevant to the system app but the core methods for import should translate well. :RudyLu ping me if you have any questions.
Created attachment 668385 [details] Patch - pull request 5689
Attachment #668385 - Flags: review?(jlal)
I reviewed on github. I would love, love love!!! to have these changes landed they would make calendar so much more sane :)
Hi James, Sorry for the delay due to a trip to Beijing. I have updated the unit test part as you mentioned. I have removed the tests on comparing the HTML of _renderMonth() & display() because now display() would set a specific date as "class="selected". Please let me know if you have any other suggestions on this. - https://github.com/mozilla-b2g/gaia/pull/5689/files#L4L376 Thanks.
Attachment #668385 - Flags: review?(jlal) → review+
Assignee: nobody → rlu
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Device: Unagi Build ID: 20121231070201 Does not reproduce.
You need to log in before you can comment on or make changes to this bug.