Closed
Bug 796756
Opened 12 years ago
Closed 12 years ago
[keyboard] Input type[date|time] does not handle initial values correctly.
Categories
(Firefox OS Graveyard :: Gaia, defect)
Firefox OS Graveyard
Gaia
Tracking
(blocking-basecamp:+)
VERIFIED
FIXED
blocking-basecamp | + |
People
(Reporter: ghtobz, Assigned: rudyl)
References
Details
(Whiteboard: [label:Keyboard & IME][label:needsGeckoSupport][label:calendar])
Attachments
(1 file)
[GitHub issue by lightsofapollo on 2012-09-27T10:49:54Z, https://github.com/mozilla-b2g/gaia/issues/5296] With a start value date|time should start the picker at the correct value.
[GitHub comment by lightsofapollo on 2012-09-27T11:00:38Z] https://bugzilla.mozilla.org/show_bug.cgi?id=794878 <- bugzilla side of the issue.
[GitHub comment by autonome on 2012-09-28T07:04:25Z] is there any gaia-side work when platform fix lands?
[GitHub comment by lightsofapollo on 2012-09-28T07:05:50Z] yes, we will need to parse the value passed from gecko into something we can use to update the date & time pickers. I have code for this landed in calendar for my own uses we can use the same or similar logic in the system app.
Comment 4•12 years ago
|
||
The platform fix has landed. James, can you link the calendar code, so someone else can implement for the system app?
Comment 5•12 years ago
|
||
Yes, https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/js/input_parser.js Its ready to be directly dropped into the system app if the "Calendar." part is removed. The InputParser deals with both import (string -> object) and export (date -> string) so not everything is relevant to the system app but the core methods for import should translate well. :RudyLu ping me if you have any questions.
Assignee | ||
Comment 6•12 years ago
|
||
Attachment #668385 -
Flags: review?(jlal)
Assignee | ||
Updated•12 years ago
|
Attachment #668385 -
Attachment is patch: false
Attachment #668385 -
Attachment mime type: text/plain → text/html
Comment 7•12 years ago
|
||
I reviewed on github. I would love, love love!!! to have these changes landed they would make calendar so much more sane :)
Assignee | ||
Comment 8•12 years ago
|
||
Hi James, Sorry for the delay due to a trip to Beijing. I have updated the unit test part as you mentioned. I have removed the tests on comparing the HTML of _renderMonth() & display() because now display() would set a specific date as "class="selected". Please let me know if you have any other suggestions on this. - https://github.com/mozilla-b2g/gaia/pull/5689/files#L4L376 Thanks.
Updated•12 years ago
|
Attachment #668385 -
Flags: review?(jlal) → review+
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → rlu
Status: NEW → ASSIGNED
Assignee | ||
Updated•12 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
Device: Unagi Build ID: 20121231070201 Does not reproduce.
You need to log in
before you can comment on or make changes to this bug.
Description
•