Exactly root JSTraceOp and FinalizeOp

RESOLVED FIXED in mozilla18

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla18
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Patch coming shortly.
This patch converts the |JSObject *| parameter in JSTraceOp to JSRawObject,
and does likewise for all instances of JSTraceOp.  Thus it's a functional 
no-op, but still useful to get rid of some |JSObject *|s.
Attachment #666864 - Flags: review?(terrence)
Blocks: ExactRooting
This one's just like the previous patch, but for FinalizeOp.
Attachment #666870 - Flags: review?(terrence)
Summary: Exactly root JSTraceOp → Exactly root JSTraceOp and FinalizeOp
Comment on attachment 666864 [details] [diff] [review]
Exactly root JSTraceOp.

Review of attachment 666864 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for taking this!
Attachment #666864 - Flags: review?(terrence) → review+
Comment on attachment 666870 [details] [diff] [review]
(part 2) - Exactly root FinalizeOp.

Review of attachment 666870 [details] [diff] [review]:
-----------------------------------------------------------------

It's nice to see exactly which JS classes have a finalizer hook set.
Attachment #666870 - Flags: review?(terrence) → review+
> It's nice to see exactly which JS classes have a finalizer hook set.

I temporarily added an extra, dummy argument to both JSTraceOp and FinalizeOp to make sure I (well, the compiler really) caught all of them :)
https://hg.mozilla.org/mozilla-central/rev/8694a4aa91cf
https://hg.mozilla.org/mozilla-central/rev/d552f2d2337f
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla18
You need to log in before you can comment on or make changes to this bug.