796788 - [sms] links in sms messages are not clickable

Status: VERIFIED DUPLICATE of bug 838005

(Firefox OS Graveyard :: Gaia::SMS, defect, P3)

Description

[GH to BZ]

[GitHub issue by autonome on 2012-09-28T21:34:28Z, https://github.com/mozilla-b2g/gaia/issues/5458]
they should be. it's a web phone.

Comment 1

[GH to BZ]

[GitHub comment by nhirata on 2012-09-28T23:30:34Z]
I think we need the Uris to work for this to work?

Comment 2

[GH to BZ]

[GitHub comment by autonome on 2012-09-29T21:37:15Z]
I don't understand what you mean.

I'm saying that when a URL is in the SMS text content, it's not treated as a hyperlink.

Comment 3

[GH to BZ]

[GitHub comment by borjasalguero on 2012-09-30T21:28:55Z]
@autonome You mean that when clicking an URL in a SMS message 'SMS App' should try to call an activity 'open URL' to the browser right? 
@aymanmaat What do you think about it?

Comment 4

[GH to BZ]

[GitHub comment by aymanmaat on 2012-09-30T21:43:40Z]
I think that any URL in message should be treated as a hyperlink and open the URL in a browser. It is completely self defeating if the phone cannot perform this function, and therefore we should do everything we can do to ensure that functionality is present.

Comment 5

[GH to BZ]

[GitHub comment by borjasalguero on 2012-09-30T22:01:14Z]
@aymanmaat Cool, tomorrow I will try to analyze how to do it, because I think that the best way is using an Activity. Thanks for your quick answer! I guess that this functionality should be also in 'Mail App' and in all apps which contains text right? 
@autonome Could you confirm that this functionality is available in other app in our OS? Otherwise I will try to create a common code to spread this feature to all apps through 'shared' folder. Thanks!

Comment 6

[GH to BZ]

[GitHub comment by borjasalguero on 2012-09-30T22:07:18Z]
I've found other issue about more or less the same... #2307

Comment 7

[GH to BZ]

[GitHub comment by aymanmaat on 2012-10-01T08:17:35Z]
@borjasalguero good stuff. Yes i would proactive and implement this functionality to all appropriate incoming communications that the user receives that you are covering... is it possible to make this system wide in one move?

Comment 8

[GH to BZ]

[GitHub comment by fcampo on 2012-10-01T13:40:44Z]
this seems like a feature, not a bug, so probably will not land before v1, unless policy for commits change, even if it seems like an easy stuff to do at first look

Comment 9

[GH to BZ]

[GitHub comment by borjasalguero on 2012-10-01T13:56:38Z]
@aymanmaat I would like to confirm with @autonome  about it there is any movement related in Gecko or in other apps covering the same. Otherwise Im gonna review which is the best way of achieving this functionality. As @fcampo said we have to ensure that this is gonna be considered as a 'bug' and not a 'functionality', due to the commit policy that we are using in this step of the development... @dcoloma What do you think?

Comment 10

[Daniel Coloma:dcoloma]

Hey,

 I think we need to see here the big picture, I think there are a bunch of protocols that should be handled, 

  http(s):// (because it is a web phone)
  tel:// (because it is a phone :-D)
  smsto:// (because it is a phone)
  mailto:// (because we support e-mail)

 I assume http:// is recognized by the platform. What about the other ones?

 As Borja says, I also see this as a new feature (not a bug). A feature I'd love to have :). Dietrich, how do you want to handle this one?

Comment 11

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Hi Daniel.  that's exactly what I meant about URIs.  That's tracked in bug 793310, however it doesn't seem to be working still.

Comment 12

[Dietrich Ayala (:dietrich)]

Late feature work - blocking-. If you have a patch that is reviewed, has unit tests and passes the smoketest, then attach and ask for driver approval.

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

bug 793310 has been fixed... we need various URI working within various apps.

Comment 14

[Andrea Marchesini [:baku]]

Probably the reason why this bug is still open is because of Bug 805282. Can you try to reproduce it once the patch for 805282 lands?

Comment 15

[Borja Salguero [:borjasalguero]]

Sending a SMS with 'http://www.mozilla.org' is treated as a text (not as an URL) :(

Comment 16

[Dietrich Ayala (:dietrich)]

Bug 805282 landed, is this still broken?

Comment 17

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Dietrich Ayala (:dietrich) from comment #16)
> Bug 805282 landed, is this still broken?

I guess this is more a parsing issue in the sms app. It does not automatically add <a href="http://foo.org">http://foo.org</a> for links in the message. It should probably should do that too with phone number at some point (but this is harder).

Comment 18

[Sheeri Cabral [:sheeri]]

People SMS links to follow. Might I suggest that if this can't be done quickly, the ability to copy/paste would be nice? I got a link yesterday in an SMS that I had to type into my browser (and it wasn't a simple link either!).

++ this.

Comment 20

[Andrew Sutherland [:asuth] (he/him)]

Here's the e-mail code that does this if you want to start from that.  Or improve on it and also provide a patch back to the e-mail app :)
https://github.com/mozilla-b2g/gaia-email-libs-and-more/blob/master/data/lib/mailapi/mailapi.js#L1095

and the unit tests:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/blob/master/test/unit/test_linkify.js

Comment 21

[Lucas Adamski [:ladamski]]

leo+ so not necessary to track.