796951 - Inconsistent Support Forum breadcrumbs

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task)

Description

[Scoobidiver (away)]

The breadcrumb contains Support forum in the general view and Forum in questions.

Comment 1

[Scoobidiver (away)]

Support forum is also used in the AAQ flow.

Comment 2

[makiten]

Is there another bug for localization issues? I'm new to SUMO/Mozilla dev in general, but I found a solution to this issue. However, in the process, I noticed inconsistencies on localization, at least in Japanese and in Greek.

Comment 3

[Michael Cooper [:mythmon]]

Localization issues, in general, happen through one of Mozilla's localization tools, Verbatim[1]. If the issue is simply that something is translated wrong or a translation looks funny (especially if it is only one language), it belongs there. If it looks like something wrong with the code (bad pluralization, things aren't localized in any language, breaking layouts) then it is a code issue and belongs on Bugzilla.

Welcome to SUMO!

[1]: https://localize.mozilla.org/projects/sumo/

Comment 4

[Ricky Rosario [:rrosario, :r1cky]]

The support forum listing page shows "Home > Support Forum". Most, or all, of the other pages show "Home > Forum > ...". I think we should stick with Home > Support Forum > ...". So please change "Forum" to "Support Forum" in all the breadcrumbs.

You will see them in the templates like this:

    {% set crumbs = [(url('questions.questions'), _('Forum')), (None, question.title)] %}

https://github.com/mozilla/kitsune/blob/master/apps/questions/templates/questions/answers.html#L13

Comment 5

[Michał Frontczak [:fxa90id] ♥]

Hi, can I pick it ?

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Michał Frontczak :fxa90id from comment #5)
> Hi, can I pick it ?

sure

Comment 7

[Michał Frontczak [:fxa90id] ♥]

https://github.com/mozilla/kitsune/pull/1272

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/d9fecc1b5f5a89898ed11f9874598359e367c560

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

I just deployed to prod. Thanks Michał !