Bedrock tests fail due to missing MANAGERS setting

RESOLVED INVALID

Status

www.mozilla.org
Bedrock
RESOLVED INVALID
6 years ago
5 years ago

People

(Reporter: mkelly, Assigned: mkelly)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

6 years ago
The following two tests fail on a default local setup of bedrock:

test_format_identifier_mismatch (bedrock.lib.l10n_utils.tests.test_dotlang.TestDotlang)
test_parse_utf8_error (bedrock.lib.l10n_utils.tests.test_dotlang.TestDotlang)

They fail because they check if an email was sent by code that calls mail.mail_managers, which does nothing if settings.MANAGERS is empty.

We should probably include manager@example.com or something in MANAGERS in settings/local.py-dist to allow the tests to pass. We should also probably mock the setting out during the test to better isolate it.

Updated

5 years ago
Assignee: nobody → mkelly
(Assignee)

Comment 1

5 years ago
Well hey, this was fixed at some point. Yay!
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
(Assignee)

Updated

5 years ago
Whiteboard: u=developer c=tests p=1
You need to log in before you can comment on or make changes to this bug.